Re: [PATCH] Fix h5py.

[ludo@gnu.org (Ludovic Courtès)]

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> python-h5py is currently broken.
>
>    guix environment --ad-hoc python-2.7.10 python2-h5py
>    python
>    >>> import h5py
>    [weird error]
>
> The immediate reason here is that an Egg archive is built and installed
> instead of a directory.  Python doesn’t seem to know how to import
> modules whose contents are trapped in an Egg archive (or is this only
> the case when setuptools are not in the profile?).
>
> I found that removing ‘python-setuptools’ from the ‘native-inputs’ field
> changes the behaviour such that no Egg archive is built and the library
> files are installed plainly.

OK.  We’ll have to see if other packages are affected.

> Another problem with h5py was that it didn’t actually build against our
> hdf5 library, because it looked for the library and the headers under
> ‘/opt/local’ and ‘/usr/local’.  I fixed this by adding an additional
> build phase.

Not shown here, right?

> From 5f368af582d3586a7b4e3a353d9bbd75eeb83a61 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 8 Oct 2015 13:30:23 +0200
> Subject: [PATCH 1/2] gnu: python-h5py, python2-h5py: Correct inputs.
>
> * gnu/packages/python.scm (python-h5py)
>   [inputs]: Remove python-cython and python-numpy.
>   [propagated-inputs]: New field.
>   [native-inputs]: Drop python-setuptools and add python-cython.
>   (python2-h5py): Replace "inputs" with "propagated-inputs".

I’m no expert but it makes sense to me.  The commit log is OK.

Thanks!

Ludo’.