From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add cereal + sparsehash
Date: Sat, 28 Nov 2015 16:42:39 +0100
Message-ID: <87poyut9jk.fsf@gnu.org>
References: <idjvb8oapmi.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57356)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1a2heB-0006CN-54
	for guix-devel@gnu.org; Sat, 28 Nov 2015 10:42:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1a2he6-0001mi-4m
	for guix-devel@gnu.org; Sat, 28 Nov 2015 10:42:47 -0500
In-Reply-To: <idjvb8oapmi.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Thu, 26 Nov 2015 13:53:25 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> The first patch adds a new =E2=80=9Cserialization=E2=80=9D module for lib=
raries such as
> cereal.

Maybe protobuf should be moved there?  I don=E2=80=99t know if there are ot=
her
candidates.

> The second patch adds =E2=80=9Csparsehash=E2=80=9D to the =E2=80=9Ccrypto=
=E2=80=9D module.  It=E2=80=99s
> probably not the best module for this package =E2=80=94 can you suggest a=
ny
> other location for a hash table library?

No idea, this one should be fine.

> From 19a28042f3839ea23aa13f4973172ca46cfde5f0 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Mon, 9 Nov 2015 14:46:56 +0100
> Subject: [PATCH 1/2] gnu: Add cereal.
>
> * gnu/packages/serialization.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

[...]

> +         (replace 'install
> +          (lambda* (#:key outputs #:allow-other-keys)
> +            (let* ((out     (assoc-ref outputs "out"))
> +                   (doc     (string-append out "/share/cereal/docs"))
> +                   (include (string-append out "/include/cereal")))
> +              (mkdir-p doc)
> +              (mkdir-p include)
> +              (copy-recursively "include/cereal" include)
> +              (copy-recursively "doc/html" doc))

Maybe add a comment about why =E2=80=9Cmake install=E2=80=9D isn=E2=80=99t =
enough.

Otherwise LGTM.

> From 1f8739407dd3f9715005d55befabf894fa98ee10 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Tue, 10 Nov 2015 15:41:04 +0100
> Subject: [PATCH 2/2] gnu: Add sparsehash.
>
> * gnu/packages/crypto.scm (sparsehash): New variable.

LGTM.

Thanks!

Ludo=E2=80=99.