From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Update Julia to 0.4.2.
Date: Wed, 30 Dec 2015 16:57:47 +0100
Message-ID: <87poxoszd0.fsf@gnu.org>
References: <idjh9j95qey.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57460)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aEJ8L-0002A9-Mr
	for guix-devel@gnu.org; Wed, 30 Dec 2015 10:57:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aEJ8I-0003zb-CX
	for guix-devel@gnu.org; Wed, 30 Dec 2015 10:57:53 -0500
In-Reply-To: <idjh9j95qey.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Wed, 23 Dec 2015 12:56:53 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> this patch series updates our =E2=80=9Cjulia=E2=80=9D package to version =
0.4.2.  An
> update to version 1.3.1 of =E2=80=9Cutf8proc=E2=80=9D was required.  I al=
so made the
> dependency on a patched version of =E2=80=9Clibuv=E2=80=9D explicit by cr=
eating a
> separate =E2=80=9Cjulia-libuv=E2=80=9D package.

Sounds good.

> Unfortunately, the build for =E2=80=9Cjulia=E2=80=9D is not reproducible.=
  I haven=E2=80=99t yet
> investigated what might be the cause and I don=E2=80=99t know yet how lar=
ge the
> difference between two builds is.

Julia is not mentioned in packages.yml in
<git://git.debian.org/git/reproducible/notes.git>, so I guess nobody has
looked at it yet.

When you have diff or Diffoscope info about the differences, please open
a bug.

> From 416b5a0ef40cd2dff304db55846a258210388bb3 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Mon, 30 Nov 2015 14:31:02 +0100
> Subject: [PATCH 1/3] gnu: utf8proc: Update to 1.3.1.
>
> * gnu/packages/textutils.scm (utf8proc): Update to 1.3.1.
> [arguments]: Remove custom "install" phase.

OK.

> From 034cdddd452c036d5155a56da35d20e97d0e9f28 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Mon, 30 Nov 2015 14:22:18 +0100
> Subject: [PATCH 2/3] gnu: Add libuv-julia.
>
> * gnu/packages/julia.scm (libuv-julia): New variable.

[...]

> +(define-public libuv-julia

Perhaps this can be kept private?  If not, I would suggest changing the
=E2=80=98synopsis=E2=80=99 field as well.

Otherwise LGTM.

> From 22027c25fd92c5f9821539fcf0b63fe763104ac0 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Mon, 30 Nov 2015 14:25:53 +0100
> Subject: [PATCH 3/3] gnu: julia: Update to 0.4.2.
>
> * gnu/packages/patches/julia-0.3.10-fix-empty-array.patch: Remove file.
> * gnu-system.am (dist_patch_DATA): Remove it.
> * gnu/packages/julia.scm (julia): Update to 0.4.2.
> [arguments]: Remove phase "fix-building-with-mcjit-llvm"; replace phase
> "patch-include-path" with "fix-include-and-link-paths"; add phase
> "hardcode-paths"; add missing make-flags.
> [inputs]: Replace "pcre" with "pcre2"; replace "git" with "libgit2"; add
> "coreutils"; add "libuv-julia"; add "wget"; add "which".
> [native-inputs]: Remove "which".

LGTM.

Thanks, and sorry for the delay!

Ludo=E2=80=99.