Re: [PATCHES] Add docker-compose and missing prerequisites.

[ludo@gnu.org (Ludovic Courtès)]

"Thompson, David" <dthompson2@worcester.edu> skribis:

> As much as I dislike it, the company I work for has started to use
> Docker.  Docker Compose is a special Python program that talks to the
> Docker daemon to run many containers at once using configuration from
> a "declarative" YAML file (my kingdom for an sexp), and I didn't want
> to use pip to install it.  So, here's 8 patches that add it and the
> stuff that was missing for it.

Cool, I’m glad you’re bringing Docker to Guix!  ;-)

> From 29aa112adc961c806a56e03c9031c1385ad29f37 Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson@vistahigherlearning.com>
> Date: Mon, 11 Jan 2016 13:24:30 -0500
> Subject: [PATCH 1/8] gnu: Add version 2.7 variant of python-requests.
>
> * gnu/packages/python.scm (python-requests-2.7): New variable.

OK.

> From 41af50a9a40a7668e1069cf3a94c58c73dc50452 Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson@vistahigherlearning.com>
> Date: Mon, 11 Jan 2016 13:26:07 -0500
> Subject: [PATCH 2/8] gnu: Add python-vcversioner.
>
> * gnu/packages/python.scm (python-vcversioner, python2-vcversioner): New
> variables.

OK.

> From 4609db7c4569b047f8357133dafacf3a3a418032 Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson@vistahigherlearning.com>
> Date: Mon, 11 Jan 2016 13:26:47 -0500
> Subject: [PATCH 3/8] gnu: Update python-jsonschema to 2.5.1.
>
> * gnu/packages/python.scm (python-jsonschema): Update to 2.5.1.

Please mention the new input.  Otherwise LGTM.

> From 43b8e05406a62d0b201df9aac7c6bcc9ea74a92f Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson@vistahigherlearning.com>
> Date: Mon, 11 Jan 2016 13:27:31 -0500
> Subject: [PATCH 4/8] gnu: Add python-texttable.
>
> * gnu/packages/python.scm (python-texttable, python2-texttable): New
> variables.

OK.

> From 067d7792cc2acffac1531f71f53c5b4b5f2f7c68 Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson@vistahigherlearning.com>
> Date: Mon, 11 Jan 2016 13:28:05 -0500
> Subject: [PATCH 5/8] gnu: Add python-websocket-client.
>
> * gnu/packages/python.scm (python-websocket-client): New variable.

OK.

> From 2e7b4c0a0d05330a3aefe33b9e90ef8e424bde0b Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson@vistahigherlearning.com>
> Date: Mon, 11 Jan 2016 13:30:10 -0500
> Subject: [PATCH 6/8] gnu: Add python-docker-py.
>
> * gnu/packages/docker.scm: New file.
> * Makefile.am (GNU_SYSTEM_MODULES): Add it.

[...]

> +    (home-page "https://github.com/docker/docker-py/")
> +    (synopsis "Python client for Docker")
> +    (description "Docker-Py is a Python client for Docker.")

s/for Docker/for the Docker container management tool/ maybe?

Otherwise LGTM.

> From 5f60f1d7668f585129d0e17d36d83b8f8623d680 Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson@vistahigherlearning.com>
> Date: Mon, 11 Jan 2016 13:35:51 -0500
> Subject: [PATCH 7/8] gnu: Add python-dockerpty.
>
> * gnu/packages/docker.scm (python-dockerpty): New variable.

OK.

> From 694a2a3791f873b454f4ed8b8c4e4a4e674a9d0b Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson@vistahigherlearning.com>
> Date: Mon, 11 Jan 2016 13:36:26 -0500
> Subject: [PATCH 8/8] gnu: Add docker-compose.
>
> * gnu/packages/docker.scm (docker-compose): New variable.

[...]

> +    (home-page "https://www.docker.com/")
> +    (synopsis "Multi-container orchestration for Docker")
> +    (description "Multi-container orchestration for Docker")

Could you improve the description?

Otherwise LGTM.

Thank you!

Ludo’.