From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: boost: Enable tests. Date: Wed, 20 Jan 2016 23:34:50 +0100 Message-ID: <87powvvq0l.fsf@gnu.org> References: <2d4c3c574717ab1fceddcfd58de7bf37@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aM1L8-00033w-9H for guix-devel@gnu.org; Wed, 20 Jan 2016 17:34:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aM1L3-0005gn-Un for guix-devel@gnu.org; Wed, 20 Jan 2016 17:34:58 -0500 In-Reply-To: <2d4c3c574717ab1fceddcfd58de7bf37@openmailbox.org> (Eric Bavier's message of "Fri, 15 Jan 2016 14:59:04 -0600") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Eric Bavier Cc: Guix-devel Eric Bavier skribis: > This patch turns boost package tests on. 22 of 120 test suites are > skipped due to know test failures, many of which still fail with the > upstream development version > (http://www.boost.org/development/tests/master/developer/summary.html). > > Building and running the tests obviously adds to the overall build > time, but I think most of us here are in agreement that running tests > is better than not. Definitely! Especially for a widely-used library. > It would be nice to get this patch tested on MIPS or ARM, in case > there are other failing test suites that should be documented and > skipped on those systems. Yeah. I think we=E2=80=99ll have to create a branch anyway, so when we do, we can= wait and see what Hydra reports. > From 76322bff6b4de1c0fe810506f451de733c60683a Mon Sep 17 00:00:00 2001 > From: Eric Bavier > Date: Fri, 15 Jan 2016 14:46:26 -0600 > Subject: [PATCH] gnu: boost: Enable tests. > > * gnu/packages/boost.scm (boost)[arguments]: Replace 'check' phase. [...] > + ;; The provided method for running all tests (executing b2 i= n the > + ;; "status" directory) requires a large amount of disk space > + ;; (>20G) because it does not clean up build artifacts after > + ;; successfully running a test suite. So instead we run eac= h test > + ;; individually, which only requires ~7.7G. This is still a lot of disk space. Can you make sure that everything is built with -g0? It makes a significant difference for C++ code. I did that notably for GCC and Inkscape. > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((b2 (string-append (getcwd) "/b2")) > + (test-dirs > + ;; The instructions at > + ;; http://www.boost.org/development/running_regress= ion_tests.html > + ;; to run b2 in each libs//test is not ent= irely > + ;; accurate. Some tests are in subdirectories and = others > + ;; in top-level directories. So instead we read th= e list > + ;; of test directories from status/Jamfile.v2 > + (let ((port (open-input-file "status/Jamfile.v2")) > + (start-rx (make-regexp "^run-tests libs :")) > + (end-rx (make-regexp "^[[:space:]]*;")) > + (dir-rx (make-regexp "^[[:space:]]*([a-z0-9/_= ]+)"))) I think it would be nicer to make it a procedure and move it to a =E2=80=98define=E2=80=99 at the top of the lambda. > + (reverse! dirs))) =E2=80=98reverse=E2=80=99 is enough. :-) Otherwise LGTM. I think we should wait until =E2=80=98core-updates=E2=80=99 is merged, and = then you can push an updated patch to, say, =E2=80=98wip-boost-tests=E2=80=99 based on = =E2=80=98master=E2=80=99. WDYT? Thanks! Ludo=E2=80=99.