From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Allan Webber Subject: Re: [PATCH 13/18] gnu: Add python-amqp. Date: Fri, 19 Feb 2016 16:41:59 -0800 Message-ID: <87povsnre3.fsf@dustycloud.org> References: <878u2lsg73.fsf@dustycloud.org> <20160216020319.GK3984@jasmine> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWvdX-0004Am-Cx for guix-devel@gnu.org; Fri, 19 Feb 2016 19:43:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWvdV-0007f9-Pz for guix-devel@gnu.org; Fri, 19 Feb 2016 19:43:03 -0500 Received: from dustycloud.org ([2600:3c02::f03c:91ff:feae:cb51]:50068) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWvdV-0007f5-Iy for guix-devel@gnu.org; Fri, 19 Feb 2016 19:43:01 -0500 In-reply-to: <20160216020319.GK3984@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari writes: > On Mon, Feb 15, 2016 at 03:32:16PM -0800, Christopher Allan Webber wrote: >> From dedac86054cf1526731411b8b505084dd375de17 Mon Sep 17 00:00:00 2001 >> From: Christopher Allan Webber >> Date: Sun, 14 Feb 2016 12:44:03 -0800 >> Subject: [PATCH 13/18] gnu: Add python-amqp. >> >> * gnu/packages/python.scm (python-amqp, python2-amqp): New variables. >> --- >> gnu/packages/python.scm | 38 ++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 38 insertions(+) >> >> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm >> index 82a467b..f9ad796 100644 >> --- a/gnu/packages/python.scm >> +++ b/gnu/packages/python.scm >> @@ -7895,3 +7895,41 @@ and provides a uniform API regardless of which JSON implementation is used.") >> #:python ,python-2)) >> (inputs `(("python2-setuptools" ,python2-setuptools) >> ("python2-nose" ,python2-nose))))) >> + >> +(define-public python-amqp >> + (package >> + (name "python-amqp") >> + (version "1.4.9") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (pypi-uri "amqp" version)) >> + (sha256 >> + (base32 >> + "06n6q0kxhjnbfz3vn8x9yz09lwmn1xi9d6wxp31h5jbks0b4vsid")))) >> + (build-system python-build-system) >> + (native-inputs >> + `(("python-nose" ,python-nose) >> + ("python-mock" ,python-mock))) >> + (home-page "http://github.com/celery/py-amqp") >> + (synopsis >> + "Low-level AMQP client for Python (fork of amqplib)") >> + (description >> + "This is a fork of amqplib which was originally written by Barry Pederson. >> +It is maintained by the Celery project, and used by kombu as a pure python >> +alternative when librabbitmq is not available.") >> + (license lgpl2.1+) >> + (properties `((python2-variant . ,(delay python2-amqp)))))) >> + >> +(define-public python2-amqp >> + (let ((amqp (package-with-python2 >> + (strip-python2-variant python-amqp)))) >> + (package >> + (inherit amqp) >> + (arguments `(;; Tries to run coverage tests with nose-cover3, which seems >> + ;; unmaintained. Weirdly, does not do this on the python 3 >> + ;; version? >> + #:tests? #f > > Do we need the python-2 version? Maybe it's not worth the effort if the > AMQP authors are depending on an unmaintained. Maybe they don't even > intend to support python-2 anymore. Maybe we don't need to. It would mean cutting out a few packages from here. The main benefit of this would be that it would be easy for me to use "guix environment" to test MediaGoblin on both Python 2 and 3... but I could still package these things locally if that isn't worth the public Guix benefit.