From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/3] gnu: Add reposurgeon.
Date: Sun, 24 Apr 2016 23:20:45 +0200
Message-ID: <87potebt5e.fsf@gnu.org>
References: <1460229985-13257-1-git-send-email-mthl@gnu.org>
	<1460229985-13257-3-git-send-email-mthl@gnu.org>
	<87bn5ddy05.fsf@gnu.org> <878u07ynih.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45914)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1auRSa-0000pO-O3
	for guix-devel@gnu.org; Sun, 24 Apr 2016 17:20:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1auRSZ-0001lD-N7
	for guix-devel@gnu.org; Sun, 24 Apr 2016 17:20:56 -0400
In-Reply-To: <878u07ynih.fsf@gnu.org> (Mathieu Lirzin's message of "Thu, 21
	Apr 2016 17:44:54 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Mathieu Lirzin <mthl@gnu.org>
Cc: guix-devel@gnu.org

Hello!

Mathieu Lirzin <mthl@gnu.org> skribis:

> ludo@gnu.org (Ludovic Court=C3=A8s) writes:

[...]

>>> +             ;; xsltproc generates random ids when the source document=
 doesn't
>>> +             ;; provide them.  This is making the build not reproducib=
le.
>>> +             (substitute* "reposurgeon.xml"
>>
>> Eventually we should fix it in libxslt along these lines:
>>
>>   https://bugzilla.gnome.org/show_bug.cgi?id=3D758148
>>
>> Could you send an updated patch?
>
> After some digging, I have found that the generated IDs were based on
> their node pointer address in the parse tree.  So I have added an
> additional patch which should be applied in the next release of libxslt.

Awesome!

(I realize that maybe we miscommunicated, given that =E2=80=9Ceventually=E2=
=80=9D is a
=E2=80=9Cfalse friend=E2=80=9D compared to French.)

> From aa709979cad4ac7d8b4ea8b34815e5ea7f4dde1d Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mthl@gnu.org>
> Date: Mon, 18 Apr 2016 23:21:42 +0200
> Subject: [PATCH 1/2] gnu: libxslt: Make generated documentation reproduci=
ble.
>
> * gnu/packages/patches/libxslt-generated-ids.patch: New file.
> * gnu/packages/patches/libxslt-remove-date-timestamps.patch: Likewise.
> * gnu/packages/xml.scm (libxslt)[source]: Use them.
> * gnu-system.am (dist_patch_DATA): Add them.

OK for =E2=80=98core-updates=E2=80=99.

We=E2=80=99ll have to merge =E2=80=98master=E2=80=99 in =E2=80=98core-updat=
es=E2=80=99 first, because of
=E2=80=98search-patches=E2=80=99.  You=E2=80=99re welcome to try it yoursel=
f if you want, but if
in doubt (in case of merge conflicts), I can do it.

> From 2e4a62093625709447bfb9e749b5bed50905669b Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mthl@gnu.org>
> Date: Fri, 8 Apr 2016 00:16:37 +0200
> Subject: [PATCH 2/2] gnu: Add reposurgeon.
>
> * gnu/packages/version-control.scm (reposurgeon): New variable.

[...]

> +    (license (list bsd-2 bsd-3))))

I overlooked it before, but a comment above stating how the list is to
be interpreted would be welcome.

OK with this change.

Thank you!

Ludo=E2=80=99.