From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Gradl Subject: Re: [PATCH] Add libiax Date: Wed, 01 Jun 2016 09:40:36 -0500 Message-ID: <87pos1eyyw.fsf@openmailbox.org> References: <87shx17pbq.fsf@openmailbox.org> <20160529004847.GA9375@jasmine> <87fuszwcno.fsf@openmailbox.org> <20160531190221.GA21454@solar> <20160531210242.GC19631@jasmine> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b87d8-0003KJ-Lx for guix-devel@gnu.org; Wed, 01 Jun 2016 11:00:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b87d4-0000Q7-Do for guix-devel@gnu.org; Wed, 01 Jun 2016 11:00:21 -0400 Received: from mail2.openmailbox.org ([62.4.1.33]:59773) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b87d4-0000Px-2a for guix-devel@gnu.org; Wed, 01 Jun 2016 11:00:18 -0400 In-Reply-To: <20160531210242.GC19631@jasmine> (Leo Famulari's message of "Tue, 31 May 2016 17:02:42 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Disposition: inline Leo Famulari writes: > On Tue, May 31, 2016 at 09:02:21PM +0200, Andreas Enge wrote: >> Hello, >> >> just a quick comment on the name: >> >> On Mon, May 30, 2016 at 02:47:55PM -0500, Lukas Gradl wrote: >> > Upstream seems to refer to the software as "iax" "libiax" and "libiax2" >> > interchangeably. The "2" was the closest thing I could find to a version >> > number. >> >> notice that the tarball name is always "correct" as the package name, unless >> upstream consistently uses a different name. In this case: >> >> + "https://gitlab.savoirfairelinux.com/sflphone/libiax2/" >> + "repository/archive.tar.gz?ref=" >> >> I would suggest to use "libiax2" as the package name (variable name and >> package NAME field), and the version number as proposed by Leo. > > Okay, so let's change the naming to libiax2, and give some more detail > about the licensing, as shown in my patch from earlier today. Then we > should be ready to merge :) OK, I changed the name to libiax2 and added the license field + comment from your patch. A big Thank you to everyone for their input! I still feel fairly unsure about what I am doing, so I really appreciate that! Best, Lukas --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-gnu-telephony-Add-libiax2.patch Content-Transfer-Encoding: quoted-printable > From 4ce8aa5e14f4895402ea8312a9e99e29192221c2 Mon Sep 17 00:00:00 2001 From: Lukas Gradl Date: Wed, 1 Jun 2016 09:33:44 -0500 Subject: [PATCH] gnu: telephony: Add libiax2. * gnu/packages/telephony.scm (libiax2): New variable. --- gnu/packages/telephony.scm | 41 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm index 50a83fb..b27dd1f 100644 --- a/gnu/packages/telephony.scm +++ b/gnu/packages/telephony.scm @@ -3,6 +3,7 @@ ;;; Copyright =C2=A9 2015 Andreas Enge ;;; Copyright =C2=A9 2015 David Hashe ;;; Copyright =C2=A9 2015 Efraim Flashner +;;; Copyright =C2=A9 2016 Lukas Gradl ;;; ;;; This file is part of GNU Guix. ;;; @@ -21,6 +22,7 @@ =20 (define-module (gnu packages telephony) #:use-module (gnu packages) + #:use-module (gnu packages autotools) #:use-module (gnu packages gnupg) #:use-module (gnu packages linux) #:use-module (gnu packages pkg-config) @@ -211,3 +213,42 @@ Real-time Transport Protocol (SRTP), the Universal Sec= urity Transform (UST), and a supporting cryptographic kernel.") (home-page "https://github.com/cisco/libsrtp") (license bsd-3))) + +(define-public libiax2 + (let ((commit "0e5980f1d78ce462e2d1ed6bc39ff35c8341f201")) + ;; This is the commit used by the Ring Project. + (package + (name "libiax2") + (version (string-append "0.0.0-1." (string-take commit 7))) + (source + (origin + (method url-fetch) + (uri + (string-append + "https://gitlab.savoirfairelinux.com/sflphone/libiax2/" + "repository/archive.tar.gz?ref=3D" + commit)) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "0cj5293bixp3k5x3hjwyd0iq7z8w5p7yavxvvkqk5817hjq386y2")))) + (build-system gnu-build-system) + (native-inputs + `(("autoconf" ,autoconf) + ("automake" ,automake) + ("libtool" ,libtool))) + (arguments + `(#:phases (modify-phases %standard-phases + (add-before 'configure 'autoconf + (lambda _ + (zero? (system* "autoreconf" "-vfi"))))))) + (home-page "https://gitlab.savoirfairelinux.com/sflphone/libiax2") + (synopsis "Inter-Asterisk-Protocol library") + (description "LibIAX2 implements the Inter-Asterisk-Protocol for rel= aying +Voice-over-IP (VoIP) communications.") + ;; The file 'src/md5.c' is released into the public domain by RSA Da= ta + ;; Security. The files 'src/answer.h', 'src/miniphone.c', + ;; 'src/options.c', 'src/options.h', 'src/ring10.h', 'src/winiphone.= c' are + ;; covered under the 'GPL'. + ;; The package as a whole is distributed under the LGPL 2.0. + (license (list lgpl2.0 public-domain gpl2+))))) --=20 2.7.4 --=-=-=--