From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: Add higan. Date: Wed, 08 Jun 2016 14:37:32 +0200 Message-ID: <87porrkgab.fsf@gnu.org> References: <87fustalcn.fsf@T420.taylan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAcjv-0001un-Dt for guix-devel@gnu.org; Wed, 08 Jun 2016 08:37:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAcjp-0000AY-Cx for guix-devel@gnu.org; Wed, 08 Jun 2016 08:37:42 -0400 In-Reply-To: <87fustalcn.fsf@T420.taylan> ("Taylan Ulrich \=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\= message of "Sat, 04 Jun 2016 02:44:40 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Taylan Ulrich =?utf-8?Q?=22Bay=C4=B1rl=C4=B1?= =?utf-8?Q?=2FKammer=22?= Cc: guix-devel@gnu.org taylanbayirli@gmail.com (Taylan Ulrich "Bay=C4=B1rl=C4=B1/Kammer") skribis: > Some things to note about this package & questions: > > - There's no official VCS repo and the author doesn't want automated > tools to download files from his homepage; there's an unofficial git > repo at GitLab but I found it unsuitable so I'm hosting the sources > specifically for Guix at GitHub now: > > https://github.com/TaylanUB/higan In what sense is it unsuitable? It=E2=80=99s OK to have a couple of patche= s, but it=E2=80=99s not quite OK to host a fork of the upstream package, IMO (= at the very least, it can create confusion and make it harder to see how it differs from the =E2=80=9Creal=E2=80=9D package.) > - I forgot if there's a guideline for this: the release versions are > called 'v097', 'v098' etc. with always a 'v' in front. Should that > 'v' appear in the version field of the package or should it be > stripped? I=E2=80=99d strip it. > - As seems to be tradition among emulator developers, the build system > and the program's handling of the file system are a big pile of poo, > so: > > * Is it principally OK to reuse the standard `build' and `install' > phase procedures a second time, just with the CWD changed, as I do > here? It=E2=80=99s OK, though I often find it clearer to use =E2=80=98with-directory-excursion=E2=80=99 so that we can more easily reaso= n about the current directory. > * The program insists on looking in ~/.local/share for some data files > that are actually installed in $prefix/share; does my strategy here > look OK, in that I wrap the executable to copy the data files into > ~/.local/share every time the program is run? Sounds like a sledgehammer no? :-) If those files are immutable, what about patching Higan to look for those files in $datadir instead? Thanks, and sorry for the delay! Ludo=E2=80=99.