From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kei Kebreau Subject: Re: [PATCH] gnu: Add p7zip. Date: Wed, 03 Aug 2016 22:45:52 -0400 Message-ID: <87popp45gf.fsf@openmailbox.org> References: <87a8gwxa9c.fsf@openmailbox.org> <87y44f4plm.fsf@mdc-berlin.de> <87a8gvxj1x.fsf@openmailbox.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bV8fv-0006JO-Mn for guix-devel@gnu.org; Wed, 03 Aug 2016 22:46:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bV8fr-0006GR-Gn for guix-devel@gnu.org; Wed, 03 Aug 2016 22:46:22 -0400 Received: from mail.openmailbox.org ([62.4.1.34]:36707) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bV8fr-0006GI-6T for guix-devel@gnu.org; Wed, 03 Aug 2016 22:46:19 -0400 In-Reply-To: <87a8gvxj1x.fsf@openmailbox.org> (Kei Kebreau's message of "Tue, 02 Aug 2016 11:54:50 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Kei Kebreau writes: > Ricardo Wurmus writes: > >> Hi Kei, >> >>> This patch should install p7zip correctly on every architecture >>> supported by Guix. Ideally, this should be tested it on each arch for >>> the sake of completeness and safety. I've got x86_64 covered so far. :-) >> >> thank you for this patch! >> >> I see that you took care of removing non-free parts in a patch and a >> build phase. Since =E2=80=9Cguix build -S p7zip=E2=80=9D doesn=E2=80=99= t run the build phase >> users would still end up with a source archive containing the non-free >> parts. The best way is thus to remove things in a snippet. >> >> In =E2=80=9Cshogun=E2=80=9D from the =E2=80=9Cmachine-learning=E2=80=9D = module we remove supporting code >> for non-free features in a snippet by cutting out anything between some >> ifdef markers, but looking at the patch I see that it wouldn=E2=80=99t be >> feasible for p7zip. >> > > Perhaps I can just clear the non-free files and add that to the patch? Never mind, I read your email incorrectly. After looking at many of the snippets in the Guix tree, I agree that the equivalent for p7zip would be quite large and unwieldy. Perhaps there is pre-sanitized p7zip code to pull from if a patch can't be used? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXoqxhAAoJEOal7jwZRnoN+LwQAKzlIfn5/A3ZhB5CbJa4srBe cXSGKe/I0aI4Qbd1Zyc9/Epv4YNh7FKwPxGT/Osv4OR6koxZWSfHUoxZwTJDayrG R6OW6ukqIV2wStwhC67v7BHlBhp4cYWB0Cka2vEJy+dtjKx/reF2MzNd8Fo+0I+V /sJAB1+jV1ZUAv7gfOs2rf4xu8NI3uNt+C4RXKP659aJGtEPTQqrQh7++5+pqQAf cmkJVOJ57ZOxaKhSpLYJpDDCJemq2HaNwv8h0ihuTuvRXeV1tOzMfAYrbiWFo+kx 5G+zbZ98V1oswrpGhsJDOflaK4gmbI1J9+UMvGQXwXl6BoFxeYwByQFtuSyrmv4x EocKQMgHKquN9Rit4FXyRrd59CJqgfboihcsPeCGqBT/tNlWDRAZrdjabVYHVAah RyW8uGhmThpCFKx8oV4ExmVIcDy51etS2qzEEmm1deUZLdHeFgVP1lnG/NrYkdtA MQY2qXQkXeTJAC8G1Lb27ujUIp0IoFHhzHFqhNkjTHyMMfm/0JhBsmuBH+AEopGG NiVk5GYb70AXLKVltBY0PMXFaYCNBzEME7w4jEhukwQoHRyvx/3KvKqGWfUFitdf AYJelY1G7s4Gyo4fA1dO9iQDvV0H463JRQpWw0Bp3SlkypP/ZR63HKe92tZ9jsOT 64xFD1z+mW5Cvn738Pn1 =9Z6J -----END PGP SIGNATURE----- --=-=-=--