From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#24105: git package misses man pages
Date: Wed, 17 Aug 2016 11:33:54 +0200
Message-ID: <87pop7u4cd.fsf@gnu.org>
References: <20160729124623.GA31006@solar> <20160729171059.GA14354@jasmine>
	<87vaznb5my.fsf@gnu.org> <20160809190302.GA13796@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53856)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1bZxEb-00031E-1B
	for bug-guix@gnu.org; Wed, 17 Aug 2016 05:34:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1bZxEX-0001un-QW
	for bug-guix@gnu.org; Wed, 17 Aug 2016 05:34:02 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:33810)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1bZxEX-0001uX-Ne
	for bug-guix@gnu.org; Wed, 17 Aug 2016 05:34:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1bZxEX-0008Bt-JU
	for bug-guix@gnu.org; Wed, 17 Aug 2016 05:34:01 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.24105.B24105.147142643931476@debbugs.gnu.org>
In-Reply-To: <20160809190302.GA13796@jasmine> (Leo Famulari's message of "Tue,
	9 Aug 2016 15:03:02 -0400")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: 24105@debbugs.gnu.org

Leo Famulari <leo@famulari.name> skribis:

> On Sat, Jul 30, 2016 at 03:46:29PM +0200, Ludovic Court=C3=A8s wrote:
>> Leo Famulari <leo@famulari.name> skribis:
>>=20
>> > On Fri, Jul 29, 2016 at 02:46:23PM +0200, Andreas Enge wrote:
>>=20
>> [...]
>>=20
>> >> I suggest to include the man pages into the git package itself. If bu=
ilding
>> >> them is a real issue, adding a source and the build phase of git-manp=
ages
>> >> to the git package itself could also be an option.
>> >
>> > I agree. If we continue to not build them from source, it won't make t=
he
>> > Git package any more "expensive". We could add the pre-built source
>> > tarball as a native-input to the Git package, and re-use the unpack
>> > phase from git-manpages.
>>=20
>> I agree too, this sounds like a good idea.
>
> I've attached a patch. Your thoughts?
>
> From 2407216eac19e5a7a3376efc497f7047dc0c8299 Mon Sep 17 00:00:00 2001
> From: Leo Famulari <leo@famulari.name>
> Date: Tue, 9 Aug 2016 14:55:37 -0400
> Subject: [PATCH] gnu: git: Provide man-pages in main Git package.
>
> * gnu/packages/version-control.scm (git-manpages): Remove variable.
> (git)[native-inputs]: Add GIT-MANPAGES.
> [arguments]: Add 'install-man-pages' phase.

LGTM!  :-)

Thank you!

Ludo'.