Re: [PATCH] gnu: Add toxic (Need help with ncurses+libnotify not being found).

[ng0 <ng0@we.make.ritual.n0.is>]

Hi,

thanks for the CPATH info, I will try that.

Alex Kost <alezost@gmail.com> writes:

> ng0 (2016-08-21 05:25 +0300) wrote:
>
>> There are serious cosmetic improvements I need to to make on these
>> patches, I am aware of this, but what I am asking help for is:
>>
>> I've tried for hours many ways to make toxic find "libnotify" and
>> "ncursesw" ... It does not
>> happen... setenv. substitute. ldflags. user_ldflags. cflags. user_cflags. nothing..
>>
>> Can someone shed some light on this?
>
> As I see 'toxic' has a hand-written Makefile, so it probably doesn't use
> pkg-config properly to find "libnotify".  Did you try to add
> "<libnotify-store-dir>/include/libnotify" to CPATH (as it is
> done in 'webkitgtk' package, for example)?

I think so, but I will try again, thanks for the package example.

> [...]
>> +(define-public libtoxcore
>> +  (let ((revision "1")
>> +        (commit "755f084e8720b349026c85afbad58954cb7ff1d4"))
>> +    (package
>> +      (name "libtoxcore")
>> +      (version (string-append "0.0.0" "-"
>> +                              revision (string-take commit 8)))
>> +      (source (origin
>> +                (method git-fetch)
>> +                (uri (git-reference
>> +                      (url "https://github.com/irungentoo/toxcore.git")
>> +                      (commit commit)))
>> +                (file-name (string-append name "-" version))
>
> I prefer:          (file-name (string-append name "-" version "-checkout"))
> I think it is more clean.

^ see "I am aware of the fact that it needs cosmetic changes" or: wip is
very wip at my side usually, I would've changed this before an official
patch send.

>> +                (sha256
>> +                 (base32
>> +                  "0ap1gvlyihnfivv235dbrgsxsiiz70bhlmlr5gn1027w3h5kqz8w"))))
>> +      (build-system gnu-build-system)
>> +      (native-inputs
>> +       `(("autoconf" ,autoconf)
>> +         ("automake" ,automake)
>> +         ("libtool" ,libtool)
>> +         ;; TODO: Add when test suite is capable of passing.
>> +         ;; ("check" ,check)
>> +         ("pkg-config" ,pkg-config)))
>> +      (inputs
>> +       `(("libsodium" ,libsodium)
>> +         ("opus" ,opus)
>> +         ("libvpx" ,libvpx)))
>> +      (arguments
>> +       `(#:phases
>> +         (modify-phases %standard-phases
>> +           (add-before 'configure 'autoconf
>
> It should be added after 'unpack' phase, because... I forgot the reason :-)
> but it relates to other phases between 'unpack' and 'configure' on "arm"
> or "mips" systems.

This package is a version bumped + changed alist to add-after/before
package based on the pacakage davexunit has. I will adjust later.

> [...]
>> +(define-public toxic
>> +  (package
>> +    (name "toxic")
>> +    (version "0.7.0")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append "https://github.com/JFreegman/"
>> +                                  name "/archive/v" version ".tar.gz"))
>> +              (file-name (string-append name "-" version))
>
> Don't forget to change it to:
>
>                  (file-name (string-append name "-" version ".tar.gz"))
>
> -- 
> Alex

-- 
ng0
For non-prism friendly talk find me on http://www.psyced.org