From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] openssh service
Date: Mon, 29 Aug 2016 17:06:21 +0200
Message-ID: <87poor1uoi.fsf@gnu.org>
References: <20160805141840.447dd381@polymos> <87oa57jpix.fsf@igalia.com>
	<20160805162049.491063d9@polymos> <20160819160335.3ed70813@polymos>
	<CAEwRq=q7wFGp5eu-J-igSJvW9pbn7848q4viM_e61tP3ixU86w@mail.gmail.com>
	<20160819163125.0be91283@polymos>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59737)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1beO8s-0001CS-QI
	for guix-devel@gnu.org; Mon, 29 Aug 2016 11:06:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1beO8o-0005AW-DZ
	for guix-devel@gnu.org; Mon, 29 Aug 2016 11:06:29 -0400
In-Reply-To: <20160819163125.0be91283@polymos> (Julien Lepiller's message of
	"Fri, 19 Aug 2016 16:31:25 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: guix-devel <guix-devel@gnu.org>

Hi Julien,

I just discovered this patch as I go through my backlog, which is fun
because I used sshd as an example to illustrate how GuixSD services work
just a week ago.  :-)

Julien Lepiller <julien@lepiller.eu> skribis:

> +@deffn {Scheme Procedure} openssh-service [#:pidfile "/var/run/sshd.pid"=
] @

#:pid-file

> +       [#:port-number 22] [#:root-login "without-password"] @
> +       [#:allow-empty-passwords #f] [#:password-authentication? #t] @
> +       [#:pubkey-authentication? #t] [#:rsa-authentication? #t] @
> +       [#:x11-forwarding? #f] [#:protocol-number "2"]

I agree with Andy=E2=80=99s latest comments regarding naming.

Also, make sure to consistently use question marks for Boolean options,
as in #:allow-empty-passwords?.

Last thing, I would prefer to expose and document
<openssh-configuration>, as is done for Dropbear.  We should encourage
this style now, IMO.

(In commit 39012aab3333868d5ab3b39c95682f95212437e2 I enabled PAM
support in OpenSSH, though it=E2=80=99s off by default; maybe in a future p=
atch
we can add #:pam-support?.)

> --- a/gnu/packages/ssh.scm
> +++ b/gnu/packages/ssh.scm
> @@ -142,7 +142,8 @@ a server that supports the SSH-2 protocol.")
>               ("zlib" ,zlib)
>               ("xauth" ,xauth)))                   ;for 'ssh -X' and 'ssh=
 -Y'
>     (arguments
> -    `(#:test-target "tests"
> +    `(#:configure-flags `("--sysconfdir=3D/etc/ssh")
> +      #:test-target "tests"

I committed this part independently as
af493726ce16483bd09ed7f73028bab3294131e2.  :-)

> +When @var{x11-forwarding} is true, @command{ssh} options -X and -Y will =
work."

@option{-X} and @option{-Y}.

These are all cosmetic details.  If you prefer I can do it on your
behalf, just let me know; otherwise, please send an updated patch.

Thank you for your work!

Ludo=E2=80=99.