From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Vong Subject: Re: [PATCH 3/3] gnu: vlc: Add inputs. Date: Mon, 10 Oct 2016 18:38:10 +0800 Message-ID: <87pon8zdyl.fsf@gmail.com> References: <87r38sih99.fsf@gmail.com> <20160920200902.GB20679@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btXyZ-0004DF-I2 for guix-devel@gnu.org; Mon, 10 Oct 2016 06:38:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btXyT-0003Xb-Qn for guix-devel@gnu.org; Mon, 10 Oct 2016 06:38:30 -0400 Received: from mail-pa0-x241.google.com ([2607:f8b0:400e:c03::241]:32949) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btXyT-0003Wn-Gg for guix-devel@gnu.org; Mon, 10 Oct 2016 06:38:25 -0400 Received: by mail-pa0-x241.google.com with SMTP id hh10so6977492pac.0 for ; Mon, 10 Oct 2016 03:38:25 -0700 (PDT) In-Reply-To: <20160920200902.GB20679@jasmine> (Leo Famulari's message of "Tue, 20 Sep 2016 16:09:02 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Hello, Thanks for the review. I check on hydra just now and indeed some inputs does not build on all supported architectures, namely fluidsynth, gst-plugins-base, libmpeg2 and samba. So I comment them out (in case they are available in the future). Here is the new patch: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-gnu-vlc-Add-inputs.patch Content-Transfer-Encoding: quoted-printable From=20f73bc602a3c14cb7563df731b18b506423e27046 Mon Sep 17 00:00:00 2001 From: Alex Vong Date: Tue, 30 Aug 2016 02:30:57 +0800 Subject: [PATCH] gnu: vlc: Add inputs. * gnu/packages/video.scm (vlc)[inputs]: Add eudev, faad2, gtk+-2, jack-1, libass, libavc1394, libbluray, libcaca, libdca, libdvdnav, libdvdread, libmodplug, libmtp, libnotify, libraw1394, libshout, librsvg, libupnp, libva, libvdpau, taglib, twolame. =2D-- gnu/packages/video.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 5e1bdf1..75a4f60 100644 =2D-- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -63,9 +63,12 @@ #:use-module (gnu packages gl) #:use-module (gnu packages glib) #:use-module (gnu packages guile) + #:use-module (gnu packages gnome) #:use-module (gnu packages gnupg) #:use-module (gnu packages gtk) #:use-module (gnu packages image) + #:use-module (gnu packages libupnp) + #:use-module (gnu packages libusb) #:use-module (gnu packages linux) #:use-module (gnu packages lua) #:use-module (gnu packages mp3) @@ -614,20 +617,44 @@ audio/video codec library.") `(("alsa-lib" ,alsa-lib) ("avahi" ,avahi) ("dbus" ,dbus) + ("eudev" ,eudev) + ("faad2" ,faad2) ("flac" ,flac) ("ffmpeg" ,ffmpeg-2.8) ;fails to build against ffmpeg= 3.0 + ;; ("fluidsynth" ,fluidsynth) ; unavailable on armhf ("fontconfig" ,fontconfig) ("freetype" ,freetype) + ;; ("gnome-vfs" ,gnome-vfs) ; cannot be detected by configure ("gnutls" ,gnutls) + ;;("gst-plugins-base" ,gst-plugins-base) ;unavailable on armhf, mip= s64el + ("gtk+" ,gtk+-2) + ("jack" ,jack-1) ("liba52" ,liba52) + ("libass" ,libass) + ("libavc1394" ,libavc1394) + ("libbluray" ,libbluray) + ("libcaca" ,libcaca) + ("libdca" ,libdca) ("libcddb" ,libcddb) + ("libdvdnav" ,libdvdnav) + ("libdvdread" ,libdvdread) ("libgcrypt" ,libgcrypt) ("libkate" ,libkate) ("libmad" ,libmad) + ;; ("libmpeg2" ,libmpeg2) ; unavailable on armhf, mips64el + ("libmodplug" ,libmodplug) + ("libmtp" ,libmtp) + ("libnotify" ,libnotify) ("libogg" ,libogg) ("libpng" ,libpng) + ("libraw1394" ,libraw1394) ("libsamplerate" ,libsamplerate) + ("libshout" ,libshout) ("libssh2" ,libssh2) + ("librsvg" ,librsvg) + ("libupnp" ,libupnp) + ("libva" ,libva) + ("libvdpau" ,libvdpau) ("libvorbis" ,libvorbis) ("libtheora" ,libtheora) ("libxext" ,libxext) @@ -644,9 +671,12 @@ audio/video codec library.") ("qt" ,qt) ; FIXME: reenable modular qt after update - requires bui= lding ;("qtbase" ,qtbase) with -std=3Dgnu++11. ;("qtx11extras" ,qtx11extras) + ;; ("samba" ,samba) ; unavailable on mips64el ("sdl" ,sdl) ("sdl-image" ,sdl-image) ("speex" ,speex) + ("taglib" ,taglib) + ("twolame" ,twolame) ("xcb-util-keysyms" ,xcb-util-keysyms))) (arguments `(#:configure-flags =2D-=20 2.10.1 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Cheers, Alex Leo Famulari writes: > On Sat, Sep 10, 2016 at 11:08:18AM +0800, Alex Vong wrote: >> From b9e30604e432586c89c5e33b27ba609852efd399 Mon Sep 17 00:00:00 2001 >> From: Alex Vong >> Date: Tue, 30 Aug 2016 02:30:57 +0800 >> Subject: [PATCH 3/3] gnu: vlc: Add inputs. >>=20 >> * gnu/packages/video.scm (vlc)[inputs]: Add eudev, faad2, fluidsynth, >> gnome-vfs, gst-plugins-base, gtk+-2, jack-2, libass, libavc1394, >> libbluray, libcaca, libdca, libdvdnav, libdvdread, libmpeg2, >> libmodplug, libmtp, libnotify, libraw1394, libshout, librsvg, libupnp, >> libva, libvdpau, samba, taglib, twolame. > > My question is similar to the one for the last patch. Can you check on > if these packages build for all our supported > architectures? If so, okay for me. --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJX+2+SAAoJEG6w5RGTUYWAmgwH/iJd8yedFf/bqOkz45fdS21F sRVjGbMGc3328fzgJyiy7CnSsfsO09nnclMW9ZH7jNwmyy3s7WOg6829aEec2C8J EVXSuoYINd7/tpP/k/XjcFrclkYEleh7VQdKIu2h7bRhP88x26c4219duCKT/9Vc 03pS0E5ZFDdn6zvn3zED6vuJj/rxCuds/hit4BU9nWi7F3HtdOhS0HYizpsOSD/Y fbKZWtH4UNQNGPea0icUWgWngrU7xs1FbFTAOUZzQiHNYvieSN2S5alntmMBZT48 j417H+pUuvodGDMtF1c4x8XOFNh8JW+YhqQnBwl9AD/iZCB8fM1sBOYVsgo6yR4= =LI1V -----END PGP SIGNATURE----- --==-=-=--