From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Allow nfs file systems to be automatically mounted.
Date: Mon, 28 Nov 2016 14:59:09 +0100
Message-ID: <87polfbt8y.fsf@gnu.org>
References: <8760nc6et6.fsf@gnu.org>
	<1480152990-7080-1-git-send-email-jmd@gnu.org>
	<87fumenl44.fsf@gnu.org> <20161126193358.GA10000@jocasta.intra>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46235)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cBMSg-0007QY-QK
	for guix-devel@gnu.org; Mon, 28 Nov 2016 08:59:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cBMSd-0006ux-Mg
	for guix-devel@gnu.org; Mon, 28 Nov 2016 08:59:14 -0500
In-Reply-To: <20161126193358.GA10000@jocasta.intra> (John Darrington's message
	of "Sat, 26 Nov 2016 20:33:58 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: John Darrington <john@darrington.wattle.id.au>
Cc: guix-devel@gnu.org, John Darrington <jmd@gnu.org>

John Darrington <john@darrington.wattle.id.au> skribis:

> On Sat, Nov 26, 2016 at 07:37:15PM +0100, Ludovic Court??s wrote:
>      John Darrington <jmd@gnu.org> skribis:
>=20=20=20=20=20=20
>      > * gnu/build/file-systems.scm (mount-file-system): Append target ad=
dr=3D when
>      > mounting nfs filesystems.
>=20=20=20=20=20=20
>      Looks like you forgot to address some of suggestions I made
>      (???string-prefix????,=20
>
> Ok.  I will make that change.
>
>      ???match???,=20
>
> Have another look: +    (let* ((host (match (string-split source #\:) ((h=
 _) h)))

Right, but there are other occurrences of =E2=80=98car=E2=80=99 for =E2=80=
=98getaddrinfo=E2=80=99.  :-)

>      and left a question unanswered (port number?):
>
> Sorry.  The answer is, no so far as I'm aware, there is no convention whi=
ch=20
> allows a port number to  be specifed in the source field.

OK (this would have changed the way =E2=80=98source=E2=80=99 is parsed.)

>      , etc)
>
> The only other thing I think you mentioned was using "if" instead of "con=
d".
> I can envisage that in the future there will be a need for other cases,  =
-=20
> it's not just an either/or choice - so it seemed to me that cond was more=
=20
> appropriate.
>=20=20=20=20=20=20
> I am aware there is room for improvement in this patch (for example in th=
e=20
> case of IP6 addresses?)  - any help will be gratefully accepted.

=E2=80=98getaddrinfo=E2=80=99 can return both IPv4 and IPv6 addresses, so i=
n theory,
the patch is IPv6 Ready.

Ludo=E2=80=99.