all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/2] gnu: idris: Update to 0.99.
Date: Mon, 19 Dec 2016 15:13:15 +0100	[thread overview]
Message-ID: <87poko3t38.fsf@gnu.org> (raw)
In-Reply-To: <20161215172835.7300-1-david@craven.ch> (David Craven's message of "Thu, 15 Dec 2016 18:28:34 +0100")

Hi!

David Craven <david@craven.ch> skribis:

> * gnu/packages/haskell.scm (idris): Update to 0.99.

[...]

> +    (native-search-paths
> +     (list (search-path-specification
> +            (variable "IDRIS_LIBRARY_PATH")
> +            (files '("idris/libs")))))

The conventional thing would be to use “lib/idris” (just like we have
“lib/perl5”, “lib/python2.7”, “lib/guile”, etc.)  Could you make this
change?

I suppose it’s OK to make this change now since there are no Idris
libraries packaged yet.

> +++ b/gnu/packages/patches/idris-IDRIS_LIBRARY_PATH.patch
> @@ -0,0 +1,46 @@
> +From 8617ba8f391da875ea0d59c6b8fdce26b64e2abd Mon Sep 17 00:00:00 2001
> +From: David Craven <david@craven.ch>
> +Date: Sun, 6 Nov 2016 15:46:50 +0100
> +Subject: [PATCH 1/2] IDRIS_LIBRARY_PATH accepts a colon separated search path.
> +
> +* src/Idris/Imports.hs (installedPackages): SplitOn colon and concatMap
> +  the results.

Could you indicate what the upstream status of this patch is?

If you haven’t done it yet, I encourage you to submit it upstream: it
looks like there’s no reason not to have it upstream.

Otherwise LGTM.

Thank you!

Ludo’.

  parent reply	other threads:[~2016-12-19 14:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-15 17:28 [PATCH 1/2] gnu: idris: Update to 0.99 David Craven
2016-12-15 17:28 ` [PATCH 2/2] gnu: Add idris-lightyear David Craven
2016-12-19 14:14   ` Ludovic Courtès
2016-12-19 14:13 ` Ludovic Courtès [this message]
2016-12-19 14:17   ` [PATCH 1/2] gnu: idris: Update to 0.99 David Craven
2016-12-19 16:22     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87poko3t38.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=david@craven.ch \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.