From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add tipp10 touch typing tutor.
Date: Mon, 19 Dec 2016 22:39:24 +0100
Message-ID: <87poknzjhv.fsf@gnu.org>
References: <1482074241-30845-1-git-send-email-h.goebel@crazy-compilers.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38652)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cJ5ed-0003KI-8w
	for guix-devel@gnu.org; Mon, 19 Dec 2016 16:39:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cJ5eZ-00013H-7k
	for guix-devel@gnu.org; Mon, 19 Dec 2016 16:39:31 -0500
In-Reply-To: <1482074241-30845-1-git-send-email-h.goebel@crazy-compilers.com>
	(Hartmut Goebel's message of "Sun, 18 Dec 2016 16:17:21 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org

Hi!

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> * gnu/packages/education.scm (touch10): New variable.
> * gnu/packages/patches/tipp10-FixCompiling.patch,
>   gnu/packages/patches/tipp10-RemoveLicenseCode.patch: New files.
> * gnu/local.mk (dist_patch_DATA): Register them.

[...]

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://debian/pool/main/"
> +                                  "t/tipp10/tipp10_2.1.0.orig.tar.gz"))

Is there really no upstream for this program?  tipp10.com seems to be
live, no?

> +              (patches (search-patches "tipp10-FixCompiling.patch"
> +                                       "tipp10-RemoveLicenseCode.patch")=
)))

Please use lowercase and hyphens for file names.  :-)

> +    (home-page "https://www.tipp10.com/")
> +    (synopsis "Touch typing tutor")
> +    (description " TIPP10 is a free touch typing tutor for Windows, Mac =
OS and
                     ^
Extra space.

Please don=E2=80=99t mention supported operating systems; what matters is t=
hat
it works on GNU.

> +Linux.  The ingenious thing about the software is its intelligence featu=
re.

=E2=80=9CIntelligence feature=E2=80=9D sounds vague; could it be rephrased =
in more
precise terms?

> +Note: To change the language settings choose Datei (File) =E2=86=92
> +Grundeinstellungen (Generell Settings) =E2=86=92 Sprache (Language) and =
change from
> +Deutsch to English. The you have restart the program to have the change =
take
> +effect.")

This information doesn=E2=80=99t belong here.

Does Debian have patches to make this program honor the current locale?
That would be the best option.

> +    (license license:gpl2)))

Version 2 only?

> +--- a/tipp10.desktop
> ++++ b/tipp10.desktop
> +@@ -1,10 +1,10 @@
> + [Desktop Entry]
> +-Encoding=3DUTF-8
> + Name=3DTIPP10
> + Comment=3DTouch Typing Tutor
> + Comment[de]=3D10-Finger-Schreibtrainer
> +-Exec=3Dtipp10
> ++Exec=3D/usr/bin/tipp10

This doesn=E2=80=99t look useful.

Could you send an updated version?

Thank you!

Ludo=E2=80=99.