From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 3/6] gnu: Add python-cram.
Date: Tue, 17 Jan 2017 23:36:09 +0100
Message-ID: <87pojlb9gm.fsf@gnu.org>
References: <20170115203338.19769-1-mbakke@fastmail.com>
	<20170115203338.19769-4-mbakke@fastmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45003)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cTcMR-0000r6-AO
	for guix-devel@gnu.org; Tue, 17 Jan 2017 17:36:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cTcMO-0002J5-4J
	for guix-devel@gnu.org; Tue, 17 Jan 2017 17:36:15 -0500
In-Reply-To: <20170115203338.19769-4-mbakke@fastmail.com> (Marius Bakke's
	message of "Sun, 15 Jan 2017 21:33:35 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org

Marius Bakke <mbakke@fastmail.com> skribis:

> * gnu/packages/python.scm (python-cram, python2-cram): New variables.

LGTM!

> +             (substitute* "cram/_test.py"
> +               ;; This hack works around a bug triggered by substituting
> +               ;; the /bin/sh paths. "tests/usage.t" compares the output=
 of
> +               ;; "cram -h", which breaks the output at 80 characters. T=
his
> +               ;; causes the line showing the default shell to break int=
o two
> +               ;; lines, but the test expects a single line...
> +               (("env\\['COLUMNS'\\] =3D '80'")
> +                "env['COLUMNS'] =3D '160'"))

Woow, good catch.

Ludo=E2=80=99.