From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add guildhall.
Date: Tue, 17 Jan 2017 23:53:55 +0100
Message-ID: <87pojl9u2k.fsf@gnu.org>
References: <20170115210219.13148-1-rekado@elephly.net>
	<87shojz5vq.fsf@gnu.org> <87o9z68vr3.fsf@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53553)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cTcde-0005ou-JU
	for guix-devel@gnu.org; Tue, 17 Jan 2017 17:54:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cTcda-0005f1-MO
	for guix-devel@gnu.org; Tue, 17 Jan 2017 17:54:02 -0500
In-Reply-To: <87o9z68vr3.fsf@elephly.net> (Ricardo Wurmus's message of "Mon,
	16 Jan 2017 23:50:40 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org

Ricardo Wurmus <rekado@elephly.net> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> Ricardo Wurmus <rekado@elephly.net> skribis:
>>
>>> * gnu/packages/guile.scm (guildhall): New variable.
>>
>> [...]
>>
>>> +       `(;; FIXME: tests fail for unknown reason.  They seem to try to=
 load
>>> +         ;; the bash executable as a Scheme file.  See bug report at
>>> +         ;; https://github.com/ijp/guildhall/issues/22
>>> +         #:tests? #f
>>
>> I think that=E2=80=99s because Makefile.am has:
>>
>>   TESTS_ENVIRONMENT =3D $(GUILE) =E2=80=A6
>>
>> whereas it should instead do (assuming test files have the .scm
>> extension):
>>
>>   SCM_LOG_DRIVER =3D $(GUILE) =E2=80=A6
>>
>> and have =E2=80=98TESTS_ENVIRONMENT=E2=80=99 contain only environment va=
riables.
>>
>> See
>> <http://git.savannah.gnu.org/cgit/skribilo.git/commit/?id=3Dd3a740cca088=
e6ec981e4b80a10f53fcfe094511>
>> for an example of the modification that is needed.
>
> Interesting.  Do you want me to patch this in our package or should I
> just forward this info to upstream and have them fix it?  (There=E2=80=99=
s an
> open uncommented bug report about this.)

You could do both, but at least report it upstream since it=E2=80=99s easily
fixed.

TIA!
Ludo=E2=80=99.