From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH 00/10] ocaml patches Date: Wed, 18 Jan 2017 23:27:06 +0100 Message-ID: <87pojk6m2t.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <20170118202802.5073-1-julien@lepiller.eu> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTyhE-0002MF-OK for guix-devel@gnu.org; Wed, 18 Jan 2017 17:27:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cTyhB-0002hX-OE for guix-devel@gnu.org; Wed, 18 Jan 2017 17:27:12 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:41240) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cTyhB-0002hE-G1 for guix-devel@gnu.org; Wed, 18 Jan 2017 17:27:09 -0500 In-Reply-To: <20170118202802.5073-1-julien@lepiller.eu> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Julien Lepiller , guix-devel@gnu.org --=-=-= Content-Type: text/plain Julien Lepiller writes: > Here are the next 10 ocaml-related patches I would like to push. What do you > think? I don't know anything about ocaml, but the patches reads fine to me. One thing that strikes me is the usage of native-inputs; I assume it's because the packages are not referenced, but bear in mind that they are built for the architecture of the build machine, and not for the target system. E.g. `guix build --system=i686-linux ocamlify` will add 64-bit native-inputs even if the final product is supposed to be 32-bit. Not sure if that will cause problems or not. > I'm pretty sure number 9 and 10 can be improved, any idea? Not from me, I'd say it looks fine :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlh/67sACgkQoqBt8qM6 VPqKLAf/WZQOjh0V5etNZDcPxWuaJfGrzlD5BjAP+iwbI+q8Rw6yxwadSxA2mYGo 8aK7NnB6p0Kv7PNraGgbyGJPQRX3sMRm+75oSUCx7K5tyMH4NInfUQTiCM6q1g8R 3AiBn8+QzHCkUpbfTW4Qeb/d+pDWU75mRSpEm8ASiq01SJZa8dlh1C35G1WSyfd9 Jn/kpJ3wTVDNXm8M0ekQDzubJ+lbXQ2StbSk+eoFCUgxMQQoXqSCY4dndOZswbFk MJw41dVRbNFjYZCjxINiEG7YSKL/Ir0AqAkqgMAHjuEbexVSatvK61m9tzNjvOr0 3IeFlPYYNIVyflBxuAsAgUyfkXLSlg== =zrOI -----END PGP SIGNATURE----- --=-=-=--