From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: add geos Date: Mon, 23 Jan 2017 17:59:52 +0100 Message-ID: <87pojd67av.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <20170120183531.7ec19200@alma-ubu> <87vat85znn.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <20170123001251.1e2d7bef@alma-ubu> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVhyJ-00029F-Ik for guix-devel@gnu.org; Mon, 23 Jan 2017 12:00:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cVhyF-0008SI-N5 for guix-devel@gnu.org; Mon, 23 Jan 2017 11:59:59 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:35288) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cVhyF-0008SA-G6 for guix-devel@gnu.org; Mon, 23 Jan 2017 11:59:55 -0500 In-Reply-To: <20170123001251.1e2d7bef@alma-ubu> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?utf-8?Q?Bj=C3=B6rn_H=C3=B6fling?= , guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Bj=C3=B6rn H=C3=B6fling writes: > Thanks for accepting! > > I have some comments/questions below. > >> > + (arguments `(#:phases >> > + (modify-phases %standard-phases >> > + (add-after >> > + 'unpack 'patch-test-shebangs >> > + (lambda _ >> > + (substitute* >> > '("tests/xmltester/testrunner.sh" >> > + >> > "tests/geostest/testrunner.sh") >> > + (("/bin/sh") (which "bash")))=20=20 >>=20 >> Bash behaves differently based on whether it's invoked as 'bash' or >> 'sh', so I changed this to (which "sh") to be safe. > > I thought I found that sh-> "bash" substitution quite often, for example = here in nginx: > > http://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/web.scm#n148 Thanks for catching that; fixed! :-) It's something we've only recently started to take care of. Feel free to submit patches! >> > + (license license:lgpl2.1)))=20=20 >>=20 >> The files do not mention whether it's 2.1 only or later versions so we >> default to "or later". Also found a few files with other licenses. > > I also found no mentioning of "later" or not, so I thought to stick with = the > mentioned license version. What makes you use the "or later" version? This convention has been mentioned to me in passing a couple of times on this mailing list. I'm not sure where it comes from, but often double-check with Debians copyright information which settled on the same license: http://metadata.ftp-master.debian.org/changelogs/main/g/geos/geos_3.5.1-3_c= opyright --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAliGNokACgkQoqBt8qM6 VPpp0Qf7BEpvHuqf3rz9dqU/Mm93ah9jaLMmNBOTrgxjwYzubl6Ey7m0o7jWXPDk 1xs1Nzeq8mxfvu64TcR+PyW/dmjkYG1ub1dR7Tbz/inNLPFkVra7OaMGbzNE8doS 23Akk8W+X7x69Jpd+xZDlmc58o4nCeKvZXaLWz0f+zSpCdQQLU8ELdMotK7TiyBz 5i8T64t0i23tO898lLEgrI0xhqN5Y+JDsTY4U0YTdgREUQ1ZLymsKs3RaRS+J4uM QarJHrhv++FYLew6pFp9wWIlplFv6v3F0hltP6xXtc1UQbKA/fCEYW2PdZR3XlcB Lqbma2yGGNqTD3f3QjvBEEB0L8/r+A== =yRdd -----END PGP SIGNATURE----- --=-=-=--