Re: [PATCH] gnu: add geos

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1652 bytes --]

Björn Höfling <bjoern.hoefling@bjoernhoefling.de> writes:

> Thanks for accepting!
>
> I have some comments/questions below.
>
>> > +    (arguments `(#:phases
>> > +                 (modify-phases %standard-phases
>> > +                   (add-after
>> > +                       'unpack 'patch-test-shebangs
>> > +                     (lambda _
>> > +                       (substitute*
>> > '("tests/xmltester/testrunner.sh"
>> > +
>> > "tests/geostest/testrunner.sh")
>> > +                         (("/bin/sh") (which "bash")))  
>> 
>> Bash behaves differently based on whether it's invoked as 'bash' or
>> 'sh', so I changed this to (which "sh") to be safe.
>
> I thought I found that sh-> "bash" substitution quite often, for example here in nginx:
>
> http://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/web.scm#n148

Thanks for catching that; fixed! :-)

It's something we've only recently started to take care of. Feel free to
submit patches!

>> > +    (license license:lgpl2.1)))  
>> 
>> The files do not mention whether it's 2.1 only or later versions so we
>> default to "or later". Also found a few files with other licenses.
>
> I also found no mentioning of "later" or not, so I thought to stick with the
> mentioned license version. What makes you use the "or later" version?

This convention has been mentioned to me in passing a couple of times on
this mailing list. I'm not sure where it comes from, but often
double-check with Debians copyright information which settled on the
same license:

http://metadata.ftp-master.debian.org/changelogs/main/g/geos/geos_3.5.1-3_copyright

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]