From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kei Kebreau Subject: Re: [PATCH 1/5] gnu: Add libmp4v2. Date: Tue, 07 Feb 2017 15:16:07 -0500 Message-ID: <87poitiwoo.fsf@openmailbox.org> References: <20170131133501.30273-1-contact.ng0@cryptolab.net> <20170131133501.30273-2-contact.ng0@cryptolab.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbad4-0001zm-CY for guix-devel@gnu.org; Wed, 08 Feb 2017 17:22:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cbad1-000808-3s for guix-devel@gnu.org; Wed, 08 Feb 2017 17:22:22 -0500 Received: from lb1.openmailbox.org ([5.79.108.160]:51659 helo=mail.openmailbox.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cbad0-0007zP-NE for guix-devel@gnu.org; Wed, 08 Feb 2017 17:22:19 -0500 In-Reply-To: <20170131133501.30273-2-contact.ng0@cryptolab.net> (contact's message of "Tue, 31 Jan 2017 13:34:57 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: contact.ng0@cryptolab.net Cc: guix-devel@gnu.org, ng0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable contact.ng0@cryptolab.net writes: > From: ng0 > > * gnu/packages/video.scm (libmp4v2): New variable. > --- > gnu/packages/video.scm | 56 ++++++++++++++++++++++++++++++++++++++++++++= +++++- > 1 file changed, 55 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > index 8ba229e58..601364fdf 100644 > --- a/gnu/packages/video.scm > +++ b/gnu/packages/video.scm > @@ -11,7 +11,7 @@ > ;;; Copyright =C2=A9 2016 Kei Kebreau > ;;; Copyright =C2=A9 2016 Dmitry Nikolaev > ;;; Copyright =C2=A9 2016 Andy Patterson > -;;; Copyright =C2=A9 2016 ng0 > +;;; Copyright =C2=A9 2016, 2017 ng0 > ;;; Copyright =C2=A9 2016 Eric Bavier > ;;; Copyright =C2=A9 2016 Jan Nieuwenhuizen > ;;; > @@ -57,6 +57,7 @@ > #:use-module (gnu packages compression) > #:use-module (gnu packages curl) > #:use-module (gnu packages databases) > + #:use-module (gnu packages dejagnu) > #:use-module (gnu packages elf) > #:use-module (gnu packages flex) > #:use-module (gnu packages fontutils) > @@ -75,6 +76,7 @@ > #:use-module (gnu packages linux) > #:use-module (gnu packages lua) > #:use-module (gnu packages m4) > + #:use-module (gnu packages man) > #:use-module (gnu packages mp3) > #:use-module (gnu packages ncurses) > #:use-module (gnu packages ocr) > @@ -1862,3 +1864,55 @@ of modern, widely supported codecs.") > (description > "Openh264 is a library which can decode H264 video streams.") > (license license:bsd-2))) > + > +(define-public libmp4v2 > + (package > + (name "libmp4v2") > + (version "2.0.0") > + (source > + (origin > + (method url-fetch) > + ;; XXX: The new location of upstream is uncertain and will become= relevant the > + ;; moment when the googlecode archive shuts down. It is past the = date it > + ;; should've been turned off. I tried to communicate with upstrea= m, but this > + ;; wasn't very responsive and not very helpful. The short summary= is, it is > + ;; chaos when it comes to the amount of forks and only time will = tell where > + ;; the new upstream location is. > + (uri (string-append "https://storage.googleapis.com/google-" > + "code-archive-downloads/v2/" > + "code.google.com/mp4v2/mp4v2-" version ".tar.= bz2")) > + (file-name (string-append name "-" version ".tar.bz2")) > + (sha256 > + (base32 > + "0f438bimimsvxjbdp4vsr8hjw2nwggmhaxgcw07g2z361fkbj683")))) > + (build-system gnu-build-system) > + (outputs '("out" > + "static")) ; 3.7MiB .a file > + (arguments > + `(#:phases Adding a phase here that gets rid of dates and such makes the build reproducible: (add-after 'unpack 'pre-configure (lambda _ (substitute* "configure" (("PROJECT_build=3D\"`date`\"") "PROJECT_build=3D\"\"") (("ac_abs_top_builddir=3D$ac_pwd") "ac_abs_top_builddir=3D\"= \"")))) > + (modify-phases %standard-phases > + (add-after 'install 'move-static-libraries > + (lambda* (#:key outputs #:allow-other-keys) > + ;; Move static libraries to the "static" output. > + (let* ((out (assoc-ref outputs "out")) > + (lib (string-append out "/lib")) > + (static (assoc-ref outputs "static")) > + (slib (string-append static "/lib"))) > + (mkdir-p slib) > + (for-each (lambda (file) > + (install-file file slib) > + (delete-file file)) > + (find-files lib "\\.a$")) > + #t)))))) > + (native-inputs > + `(("help2man" ,help2man) > + ("dejagnu" ,dejagnu))) > + (home-page "https://code.google.com/archive/p/mp4v2/") > + (synopsis "libmp4v2 provides an API to create and modify mp4 files") The synopsis should start with an uppercase letter and not start with the package name. Perhaps you could erase everything before "API". > + (description > + "The MP4v2 library provides an API to create and modify mp4 files a= s defined by > +ISO-IEC:14496-1:2001 MPEG-4 Systems. This file format is derived from A= pple's QuickTime > +file format that has been used as a multimedia file format in a variety = of platforms and > +applications. It is a very powerful and extensible format that can acco= mmodate > +practically any type of media.") > + (license license:mpl1.1))) The rest LGTM. Could you send an updated patch? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAliaKwcACgkQ5qXuPBlG eg1UrhAAuw3zAytgPykNqi10ZSUXefrjozuon/30R34czZbjTCx8eYp0C+FmzadC FSa8IxOhzgiJIpOE4EgDlEtrd8pYAL4th1yhzpOjACqdOEPUlRc8xVjflKlKKfv2 pP5ijr3GUms4g4kZv4WKT9V2D2ocLTplG+7MeOHfiBhmQkL+Aw8QQ7lMhWRQcM6E CyiLAZQhcIMOdEV2uUT612ulVZZ6olw9SYaohpsCczxqfvdUWwAKDyQZm8sJIyBm 7ni8na1U8AB3DtRE+w5KiLtKeFW+YkqKvKnxrBPlOx+ULZPKnF5scS8ylyC2gzAu R0pgdHl8TnLHS0yisV/gtDQpEOVQwWL49hgzw3da68rLVRRgydrDxYjhEnkHfQli VAQ47XuqKzCr3HojfCpD76MpzhnJwSSyQlqQE9FVkuONKbGjb/r5wIypzBWbenI+ MLgxgPcE1CGYMmVAifTX2iCE2DfBozyWn2SSavBVojmm76IHY3Ei8IL/BJi2157l FMScr4gJS0G8NW50yPB/sxzUgIwDmeTdq/E11pPYJ7j01pVWONuqs9uMfnVgbzpJ 90JEU5lGY/3rBV1kV1FcVMQJT2p7dfCZIroRNHcdpZUmLoo2t1WKBb9GRtS4/Xze 7Ynjfwsv+RgkmuVT7LGm9f0Z8fJ8bzko2LHP4uqKRRYCvKksC00= =eCFp -----END PGP SIGNATURE----- --=-=-=--