From: Mark H Weaver <mhw@netris.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org, Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build
Date: Thu, 02 Mar 2017 20:25:24 -0500 [thread overview]
Message-ID: <87pohzup6j.fsf@netris.org> (raw)
In-Reply-To: <20170227100620.6816ae38@scratchpost.org> (Danny Milosavljevic's message of "Mon, 27 Feb 2017 10:06:20 +0100")
Danny Milosavljevic <dannym@scratchpost.org> writes:
> On Fri, 24 Feb 2017 17:13:53 -0500
> Mark H Weaver <mhw@netris.org> wrote:
>
>> If the purpose here is to facilitate mutating anything in the store,
>
> That's not what it does. It's used in the profile hook. 'union-build
> is basically just reused to avoid code duplication. See PATCH 2/2.
I see now. I withdraw my objection. Sorry for the delay.
The only remaining issue I see is that the second patch removes error
checking on the status code returned by 'mkfontscale' and 'mkfontdir'.
It would be preferable to retain that. However, it's not a serious
issue.
Regards,
Mark
next prev parent reply other threads:[~2017-03-03 1:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 0:44 [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build huang_ying_caritas
2017-02-18 0:44 ` [PATCH 2/2] guix: profiles: create fonts.dir/scale for all fonts directories huang_ying_caritas
2017-02-24 12:40 ` [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build Huang, Ying
2017-02-24 13:32 ` Andy Wingo
2017-02-25 1:03 ` Huang, Ying
2017-02-24 14:02 ` Danny Milosavljevic
2017-02-24 22:13 ` Mark H Weaver
2017-02-25 12:43 ` Huang, Ying
2017-02-27 9:06 ` Danny Milosavljevic
2017-03-03 1:25 ` Mark H Weaver [this message]
2017-02-25 1:05 ` Huang, Ying
2017-02-25 12:30 ` Huang, Ying
2017-02-26 8:23 ` 宋文武
2017-02-27 11:27 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pohzup6j.fsf@netris.org \
--to=mhw@netris.org \
--cc=alezost@gmail.com \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.