From: ludo@gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] profiles: Generate database file for manpages
Date: Wed, 05 Apr 2017 09:45:35 +0200 [thread overview]
Message-ID: <87pogrmh5s.fsf@gnu.org> (raw)
In-Reply-To: <87d1crr7nn.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 04 Apr 2017 17:59:40 -0700")
Hello!
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> Another thought/experiment:
>
> It could be interesting to use find-files with the #:fail-on-error?
> flag set to #t. When trying it:
>
> modified guix/profiles.scm
> @@ -978,7 +978,7 @@ files for the fonts of the @var{manifest} entries."
> (string-drop manpage-path (+ index (string-length "/share/man/")))))
>
> (define (populate-manpages-collection-dir entries)
> - (let ((manpages (append-map (cut find-files <> #:stat stat) entries)))
> + (let ((manpages (append-map (cut find-files <> #:stat stat #:fail-on-error? #t) entries)))
> (for-each (lambda (manpage)
> (let* ((dest-file (string-append
> manpages-collection-dir "/"
>
>
> It found a broken link for one of the manpages shipped with our gimp package.
I think we should rather do this check for instance in a new build
phase, rather than have the profile hook fail.
WDYT?
> file /gnu/store/wh2bryjss0pnrv9ss4jbbkwfbj2ql22i-gimp-2.8.18/share/man/man1/gimp-console.1
> /gnu/store/wh2bryjss0pnrv9ss4jbbkwfbj2ql22i-gimp-2.8.18/share/man/man1/gimp-console.1: broken symbolic link to gimp-console-2.8.1.gz
I wonder why this happens…
Thanks,
Ludo’.
next prev parent reply other threads:[~2017-04-05 7:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 8:35 [PATCH] profiles: Generate database file for manpages Maxim Cournoyer
2017-03-30 15:53 ` Ludovic Courtès
2017-03-31 7:12 ` Maxim Cournoyer
2017-03-31 22:44 ` Ludovic Courtès
2017-04-03 15:29 ` Maxim Cournoyer
2017-04-04 12:29 ` Ludovic Courtès
2017-04-04 14:20 ` Maxim Cournoyer
2017-04-05 0:59 ` Maxim Cournoyer
2017-04-05 7:45 ` Ludovic Courtès [this message]
2017-04-05 7:47 ` Ludovic Courtès
2017-04-05 8:09 ` Maxim Cournoyer
2017-04-05 21:00 ` Ludovic Courtès
2017-04-06 6:32 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pogrmh5s.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.