From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1czs8R-0001Yn-AM for guix-patches@gnu.org; Sun, 16 Apr 2017 17:55:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1czs8M-0000xa-EB for guix-patches@gnu.org; Sun, 16 Apr 2017 17:55:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:52844) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1czs8L-0000xO-Tk for guix-patches@gnu.org; Sun, 16 Apr 2017 17:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1czs8L-0001PY-O6 for guix-patches@gnu.org; Sun, 16 Apr 2017 17:55:01 -0400 Subject: bug#26522: gnu: Add adb Resent-Message-ID: From: Marius Bakke In-Reply-To: <20170416112200.51037253@lepiller.eu> References: <20170415183146.45f95eda@lepiller.eu> <87a87hmtv7.fsf@fastmail.com> <20170416112200.51037253@lepiller.eu> Date: Sun, 16 Apr 2017 23:54:47 +0200 Message-ID: <87pogckogo.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller , 26522@debbugs.gnu.org --=-=-= Content-Type: text/plain Julien Lepiller writes: > Hi Marius, > > thanks for the quick review. This should fix your comments. Great! One thing I overlooked last time was the patches. It would be good to include the origin in URL form, so we can dig them out later. The arch patch shouldn't be too hard to find (but URL would be convenient!), I'm curious where the other patch comes from. Patches tend to evolve over time, so checking what happened "upstream" can be handy when you're stumped. See e.g. any CVE patch for examples :) Other than that looks good! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAljz6CcACgkQoqBt8qM6 VPrTzwgAyXRumuSj1/YYCTvM/UFzH+UBUjwXBf7NrVS774qMfcK8BKOmoxgi5GY2 xQCTA/wXQUrIzGH+mCc/Hpxbc8GsjlQAXrbXqUJP0/kDdWL2h0vr9eTBXowmcDpx TO+AG1iCcLEyePKvnuLbxWB/7KdFE0QF2y9QerZ8Sk5kfSmAntkipVILZfTjqja5 ydSUVhdZsvXaqAShz+9diCPkR4RWlsobRBU1Y8W+CuFkVbqcfAFZmd9m0EALdjle 9I+Vz2VBA70DPWTWmS6twPazcMIU7goZj/s75JKjdsVKgOqtayTvEkwk4U9GpLtt UosHxlI9x0/6dGVhug7NGZ7uyxkROg== =9HKB -----END PGP SIGNATURE----- --=-=-=--