From: Marius Bakke <mbakke@fastmail.com>
To: Christopher Baines <mail@cbaines.net>, 26722-done@debbugs.gnu.org
Subject: bug#26722: [PATCH 1/3] gnu: Add python-sockjs-tornado.
Date: Tue, 02 May 2017 00:07:48 +0200 [thread overview]
Message-ID: <87pofsfcy3.fsf@fastmail.com> (raw)
In-Reply-To: <e9ec0ce1-04c8-ef66-c64c-5deb0a560180@cbaines.net>
[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]
Christopher Baines <mail@cbaines.net> writes:
> On 01/05/17 15:46, Marius Bakke wrote:
>> Hello Chris!
>>
>> Christopher Baines <mail@cbaines.net> writes:
>>
>>> * gnu/packages/python.scm (python-sockjs-tornado): New variable.
>>
>> [...]
>>
>>> +(define-public python-sockjs-tornado
>>> + (package
>>> + (name "python-sockjs-tornado")
>>> + (version "1.0.3")
>>> + (source
>>> + (origin
>>> + (method url-fetch)
>>> + (uri (string-append
>>> + "https://pypi.python.org/packages/source/"
>>> + "s/sockjs-tornado/sockjs-tornado-" version ".tar.gz"))
>>
>> Please use 'pypi-uri' here.
>>
>>> + (sha256
>>> + (base32
>>> + "16cff40nniqsyvda1pb2j3b4zwmrw7y2g1vqq78lp20xpmhnwwkd"))))
>>> + (build-system python-build-system)
>>> + (inputs
>>> + `(("python-tornado" ,python-tornado)))
>>
>> Python does not have a good mechanism for specifying exact versions of
>> runtime dependencies, so they should normally be propagated. If the
>> package does not import this at runtime (e.g. only needed for tests) it
>> should be a 'native-input'.
>>
>> LGTM with those changes.
>
> Thanks for the review Marius, I've now sent some updated patches.
Cheers! Pushed as 99aa2dce5d376b6612aab0971985f6320c03ecd2 :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-05-01 22:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-30 21:40 bug#26722: [PATCH] Add tailon Christopher Baines
2017-04-30 21:44 ` bug#26722: [PATCH 1/3] gnu: Add python-sockjs-tornado Christopher Baines
2017-04-30 21:44 ` bug#26722: [PATCH 2/3] gnu: python-tornado: Update to 4.5.1 Christopher Baines
2017-05-01 14:49 ` Marius Bakke
2017-05-01 19:28 ` Christopher Baines
2017-04-30 21:44 ` bug#26722: [PATCH 3/3] gnu: Add tailon Christopher Baines
2017-05-01 14:51 ` Marius Bakke
2017-05-01 19:30 ` Christopher Baines
2017-05-01 21:57 ` Marius Bakke
2017-05-01 14:46 ` bug#26722: [PATCH 1/3] gnu: Add python-sockjs-tornado Marius Bakke
2017-05-01 19:25 ` Christopher Baines
2017-05-01 22:07 ` Marius Bakke [this message]
2017-05-02 5:21 ` Christopher Baines
2017-05-01 19:22 ` Christopher Baines
2017-05-01 19:22 ` bug#26722: [PATCH 2/3] gnu: python-tornado: Update to 4.5.1 Christopher Baines
2017-05-01 19:22 ` bug#26722: [PATCH 3/3] gnu: Add tailon Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pofsfcy3.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=26722-done@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.