bug#26795: gnu: emacs-ag: Propagate the-silver-searcher.

bug#26795: gnu: emacs-ag: Propagate the-silver-searcher.

[Clément Lassieur]

Hi,

emacs-ag is mostly unusable via Tramp (except if the
'the-silver-searcher' store element is also in the remote system, which
will never happen if the remote system is not running Guix).

I believe 'the-silver-searcher' should be propagated, and the executable
should be 'ag' (which is the default value) instead of
'/gnu/store/...-the-silver-searcher-1.0.2/bin/ag', so that it can be
found on remote systems.

bug#26795: [PATCH] gnu: emacs-ag: Propagate the-silver-searcher.

[Clément Lassieur]

This allows emacs-ag to be used on remote systems.

* gnu/packages/emacs.scm (emacs-ag)[inputs]: Remove.  Move THE-SILVER-SEARCHER
to...
[propagated-inputs]: ... here.
[arguments]: Remove 'patch-exec-paths' phase.
---
 gnu/packages/emacs.scm | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 74f0ff8b5..3ba5fe102 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1125,13 +1125,6 @@ than @code{electric-indent-mode}.")
     (arguments
      `(#:phases
        (modify-phases %standard-phases
-         (add-before 'install 'patch-exec-paths
-           (lambda* (#:key inputs #:allow-other-keys)
-             (emacs-substitute-variables "ag.el"
-               ("ag-executable"
-                (string-append (assoc-ref inputs "the-silver-searcher")
-                               "/bin/ag")))
-             #t))
          (add-before 'install 'make-info
            (lambda _
              (with-directory-excursion "docs"
@@ -1142,14 +1135,13 @@ than @code{electric-indent-mode}.")
                     (info (string-append out "/share/info")))
                (install-file "docs/_build/texinfo/agel.info" info)
                #t))))))
-    (inputs
-     `(("the-silver-searcher" ,the-silver-searcher)))
     (native-inputs
      `(("python-sphinx" ,python-sphinx)
        ("texinfo" ,texinfo)))
     (propagated-inputs
      `(("dash" ,emacs-dash)
-       ("s" ,emacs-s)))
+       ("s" ,emacs-s)
+       ("the-silver-searcher" ,the-silver-searcher)))
     (home-page "https://github.com/Wilfred/ag.el")
     (synopsis "Front-end for ag (the-silver-searcher) for Emacs")
     (description "This package provides the ability to use the silver
-- 
2.12.2

bug#26795: gnu: emacs-ag: Propagate the-silver-searcher.

[Ludovic Courtès]

Hello Clément,

Clément Lassieur <clement@lassieur.org> skribis:

> emacs-ag is mostly unusable via Tramp (except if the
> 'the-silver-searcher' store element is also in the remote system, which
> will never happen if the remote system is not running Guix).
>
> I believe 'the-silver-searcher' should be propagated, and the executable
> should be 'ag' (which is the default value) instead of
> '/gnu/store/...-the-silver-searcher-1.0.2/bin/ag', so that it can be
> found on remote systems.

That makes sense to me.  Christopher Baines wrote it; WDYT Chris?

> This allows emacs-ag to be used on remote systems.
>
> * gnu/packages/emacs.scm (emacs-ag)[inputs]: Remove.  Move THE-SILVER-SEARCHER
> to...
> [propagated-inputs]: ... here.
> [arguments]: Remove 'patch-exec-paths' phase.

[...]

>      (propagated-inputs
>       `(("dash" ,emacs-dash)
> -       ("s" ,emacs-s)))
> +       ("s" ,emacs-s)
> +       ("the-silver-searcher" ,the-silver-searcher)))

I’d suggest writing the rationale for propagation in a comment above.

Thanks,
Ludo’.

bug#26795: gnu: emacs-ag: Propagate the-silver-searcher.

[Mathieu Othacehe]

Hi Clément & Ludo,

I also ran into the same issue. With Ludo's comment below addressed,
it's ok for me !

> I’d suggest writing the rationale for propagation in a comment above.

Thanks,

Mathieu

bug#26795: gnu: emacs-ag: Propagate the-silver-searcher.

[Clément Lassieur]

Mathieu Othacehe <m.othacehe@gmail.com> writes:

> Hi Clément & Ludo,
>
> I also ran into the same issue. With Ludo's comment below addressed,
> it's ok for me !
>
>> I’d suggest writing the rationale for propagation in a comment above.

Ok I pushed then, with the comment.  Thanks for the review :-)