From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDZAm-000869-3k for guix-patches@gnu.org; Wed, 24 May 2017 12:30:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDZAh-0001Tk-SH for guix-patches@gnu.org; Wed, 24 May 2017 12:30:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:33792) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dDZAh-0001Tg-Pg for guix-patches@gnu.org; Wed, 24 May 2017 12:30:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dDZAh-0006Xu-K1 for guix-patches@gnu.org; Wed, 24 May 2017 12:30:03 -0400 Subject: bug#26934: bug#27044: [PATCH 1/3] gnu: video: Add libzen. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Marius Bakke In-Reply-To: <20170523204306.25418-1-doubleplusgood23@gmail.com> References: <20170523204306.25418-1-doubleplusgood23@gmail.com> Date: Wed, 24 May 2017 18:29:13 +0200 Message-ID: <87poeyw752.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: "Ethan R. Jones" , 27044@debbugs.gnu.org Cc: 26934-done@debbugs.gnu.org --=-=-= Content-Type: text/plain "Ethan R. Jones" writes: > * gnu/packages/video.scm (libzen): New variable. > --- > gnu/packages/video.scm | 36 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > index b7c26a042..bc3fa48b8 100644 > --- a/gnu/packages/video.scm > +++ b/gnu/packages/video.scm > @@ -2052,3 +2052,39 @@ file format that has been used as a multimedia file format in a variety of platf > applications. It is a very powerful and extensible format that can accommodate > practically any type of media.") > (license license:mpl1.1))) > + > +(define-public libzen > + (package > + (name "libzen") > + (version "0.4.35") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://mediaarea.net/download/source/" > + name "/" version "/" > + name "_" version ".tar.bz2")) > + (file-name (string-append name "-" version ".tar.bz2")) Is it necessary to set a file-name here? IMO $name_$version is fine, but the linter may have a different opinion. > + (sha256 > + (base32 > + "12a1icgcffgv503ii2k1453kxg5hfly09mf4zjcc80aq8a6rf8by")))) > + (native-inputs > + `(("autoconf" ,autoconf) > + ("automake" ,automake) > + ("libtool" ,libtool))) > + (build-system gnu-build-system) > + (arguments > + '(#:phases > + ;; build scripts not in root of archive > + (modify-phases %standard-phases > + (add-before > + 'configure 'pre-configure > + (lambda _ > + (chdir "Project/GNU/Library"))) > + (add-before 'configure 'autogen > + (lambda _ > + (zero? (system* "./autogen.sh"))))))) > + (home-page "https://github.com/MediaArea/ZenLib") > + (synopsis "C++ utility library") > + (description "ZenLib is a C++ utility library. It includes classes for handling > +strings, configuration, bit streams, threading, translation, and cross-platform > +operating system functions.") > + (license license:bsd-2))) I don't think video.scm is a good location for this package definition. Though I'm not sure which module is most appropriate. Maybe 'code.scm'? Or perhaps create a "cpp.scm" for these generic C++ libraries? PS: No need to open separate bugs, you can just send the updated patches here. Bonus points if you add a subject prefix like "PATCH v2" for the next batch. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlkltNkACgkQoqBt8qM6 VPpj/AgAv5nBjpCaxqqbRKwsMn5RRQbg+KgXY3ygM3B+ihLerBR5Yvk2d0K59tID atIMYpouxT3LzowptfQzvfBMuYSk+hGLnfaJUfcAz1B4N/SM/TeMVrgf6eTJ5wcI pu7Kr65N8/8S779i1E+cc2kcFBqJwuzL2UofdyvNJzohYN0usfV9h8FBQocf6t6o aosRl10f70MYSwz5QNbFYpgeAw1lZQJlJn+PU+4BhhEobCJeax0dkoEHYFj+ypsO 4zR3LPfMS2zJbdJbuv6UDmLL6rPDtgkPC/0yISUDJTJCsfNOofBqrZliwag7ZRCa euAJN3JT2ceKvIKxKOr3c9YK35k5BA== =TBOv -----END PGP SIGNATURE----- --=-=-=--