From: Marius Bakke <mbakke@fastmail.com>
To: "Ethan R. Jones" <doubleplusgood23@gmail.com>, 27044@debbugs.gnu.org
Cc: 26934-done@debbugs.gnu.org
Subject: bug#26934: bug#27044: [PATCH 1/3] gnu: video: Add libzen.
Date: Wed, 24 May 2017 18:29:13 +0200 [thread overview]
Message-ID: <87poeyw752.fsf@fastmail.com> (raw)
In-Reply-To: <20170523204306.25418-1-doubleplusgood23@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2558 bytes --]
"Ethan R. Jones" <doubleplusgood23@gmail.com> writes:
> * gnu/packages/video.scm (libzen): New variable.
> ---
> gnu/packages/video.scm | 36 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index b7c26a042..bc3fa48b8 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -2052,3 +2052,39 @@ file format that has been used as a multimedia file format in a variety of platf
> applications. It is a very powerful and extensible format that can accommodate
> practically any type of media.")
> (license license:mpl1.1)))
> +
> +(define-public libzen
> + (package
> + (name "libzen")
> + (version "0.4.35")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "https://mediaarea.net/download/source/"
> + name "/" version "/"
> + name "_" version ".tar.bz2"))
> + (file-name (string-append name "-" version ".tar.bz2"))
Is it necessary to set a file-name here? IMO $name_$version is fine, but
the linter may have a different opinion.
> + (sha256
> + (base32
> + "12a1icgcffgv503ii2k1453kxg5hfly09mf4zjcc80aq8a6rf8by"))))
> + (native-inputs
> + `(("autoconf" ,autoconf)
> + ("automake" ,automake)
> + ("libtool" ,libtool)))
> + (build-system gnu-build-system)
> + (arguments
> + '(#:phases
> + ;; build scripts not in root of archive
> + (modify-phases %standard-phases
> + (add-before
> + 'configure 'pre-configure
> + (lambda _
> + (chdir "Project/GNU/Library")))
> + (add-before 'configure 'autogen
> + (lambda _
> + (zero? (system* "./autogen.sh")))))))
> + (home-page "https://github.com/MediaArea/ZenLib")
> + (synopsis "C++ utility library")
> + (description "ZenLib is a C++ utility library. It includes classes for handling
> +strings, configuration, bit streams, threading, translation, and cross-platform
> +operating system functions.")
> + (license license:bsd-2)))
I don't think video.scm is a good location for this package definition.
Though I'm not sure which module is most appropriate. Maybe 'code.scm'?
Or perhaps create a "cpp.scm" for these generic C++ libraries?
PS: No need to open separate bugs, you can just send the updated patches
here. Bonus points if you add a subject prefix like "PATCH v2" for the
next batch.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-05-24 16:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 20:43 bug#27044: [PATCH 1/3] gnu: video: Add libzen Ethan R. Jones
2017-05-23 20:43 ` bug#27045: [PATCH 2/3] gnu: video: Add libmediainfo Ethan R. Jones
2017-05-24 16:34 ` Marius Bakke
2017-05-23 20:43 ` bug#27046: [PATCH 3/3] gnu: video: Add mediainfo Ethan R. Jones
2017-05-24 16:37 ` Marius Bakke
2017-05-24 16:29 ` Marius Bakke [this message]
2017-05-27 15:19 ` bug#27044: [PATCH 1/3] gnu: cpp: libzen: Add libzen Ethan R. Jones
2017-05-27 15:19 ` bug#27044: [PATCH 2/3] gnu: video: Add libmediainfo Ethan R. Jones
2017-05-31 14:44 ` Ludovic Courtès
2017-05-27 15:19 ` bug#27044: [PATCH 3/3] gnu: video: Add mediainfo Ethan R. Jones
2017-05-31 14:44 ` bug#27044: [PATCH 1/3] gnu: cpp: libzen: Add libzen Ludovic Courtès
2017-05-27 15:34 ` bug#27044: oops Ethan R. Jones
2017-05-27 15:42 ` bug#27044: [PATCH] gnu: video: Add mediainfo Ethan R. Jones
2017-05-31 14:51 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87poeyw752.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=26934-done@debbugs.gnu.org \
--cc=27044@debbugs.gnu.org \
--cc=doubleplusgood23@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.