From: Alex Kost <alezost@gmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: 27225@debbugs.gnu.org
Subject: bug#27225: [PATCH] artwork: Use a descriptive name for the source directory.
Date: Wed, 07 Jun 2017 12:56:56 +0300 [thread overview]
Message-ID: <87poeg86jb.fsf@gmail.com> (raw)
In-Reply-To: <eefa4a48d87df42906e27c5f56f52e117ad59e4f.1496534039.git.leo@famulari.name> (Leo Famulari's message of "Sat, 3 Jun 2017 19:54:01 -0400")
Leo Famulari (2017-06-03 19:54 -0400) wrote:
> * gnu/artwork.scm (%artwork-repository): Set a descriptive file-name and
> use the full commit hash when fetching.
> ---
> gnu/artwork.scm | 19 +++++++++++--------
> 1 file changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/gnu/artwork.scm b/gnu/artwork.scm
> index 94c89143a..204845bd6 100644
> --- a/gnu/artwork.scm
> +++ b/gnu/artwork.scm
> @@ -1,5 +1,6 @@
> ;;; GNU Guix --- Functional package management for GNU
> ;;; Copyright © 2014, 2015 Ludovic Courtès <ludo@gnu.org>
> +;;; Copyright © 2017 Leo Famulari <leo@famulari.name>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -28,13 +29,15 @@
> ;;; Code:
>
> (define %artwork-repository
> - (origin
> - (method git-fetch)
> - (uri (git-reference
> - (url "git://git.savannah.gnu.org/guix/guix-artwork.git")
> - (commit "6998d30")))
> - (sha256
> - (base32
> - "0k7j3pj9s3zqiqmfkapypssvzx3f12yr0cc2rbzxqfii0b4clp1j"))))
> + (let ((commit "6998d30425289b087c64f63e7415df2241e591db"))
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "git://git.savannah.gnu.org/guix/guix-artwork.git")
> + (commit commit)))
> + (file-name (string-append "guix-artwork-" (string-take commit 7) "-checkout"))
As for me, this line is too long, I would make it:
(file-name (string-append "guix-artwork-" (string-take commit 7)
"-checkout"))
> + (sha256
> + (base32
> + "0k7j3pj9s3zqiqmfkapypssvzx3f12yr0cc2rbzxqfii0b4clp1j")))))
>
> ;;; artwork.scm ends here
--
Alex
next prev parent reply other threads:[~2017-06-07 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-03 23:54 bug#27225: [PATCH] artwork: Use a descriptive name for the source directory Leo Famulari
2017-06-06 23:12 ` Ludovic Courtès
2017-06-07 9:56 ` Alex Kost [this message]
2017-06-07 19:59 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87poeg86jb.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=27225@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.