From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dkwAo-00019a-Kb for guix-patches@gnu.org; Thu, 24 Aug 2017 13:44:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dkwAk-0007ps-A5 for guix-patches@gnu.org; Thu, 24 Aug 2017 13:44:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:44409) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dkwAj-0007pb-SD for guix-patches@gnu.org; Thu, 24 Aug 2017 13:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dkwAj-0006CG-Ld for guix-patches@gnu.org; Thu, 24 Aug 2017 13:44:01 -0400 Subject: [bug#27468] [PATCH] gnu: Add linkchecker. Resent-Message-ID: From: Marius Bakke In-Reply-To: <4a4f0a8d.AEEAPL4o3uEAAAAAAAAAAAPFd4cAAAACwQwAAAAAAAW9WABZnS4m@mailjet.com> References: <7a5dc060.AEQAMFHLF6MAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZTa-9@mailjet.com> <4cc366f5.AEMAO2lAou4AAAAAAAAAAAPNQHwAAAACwQwAAAAAAAW9WABZnL7F@mailjet.com> <87y3qb1789.fsf@fastmail.com> <4a4f0a8d.AEEAPL4o3uEAAAAAAAAAAAPFd4cAAAACwQwAAAAAAAW9WABZnS4m@mailjet.com> Date: Thu, 24 Aug 2017 19:43:19 +0200 Message-ID: <87pobk2760.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: 27468@debbugs.gnu.org --=-=-= Content-Type: text/plain Arun Isaac writes: >>> + (license (list l:gpl2+ >>> + l:bsd-2 ; linkcheck/better_exchook2.py >>> + l:bsd-3 ; linkcheck/colorama.py >>> + l:psfl ; linkcheck/gzip2.py >>> + l:expat ; linkcheck/mem.py >>> + l:isc ; third_party/dnspython >>> + l:asl2.0)))) ; third_party/miniboa >> >> Is it possible to remove these third party libraries and use packaged >> copies instead? At least 'dnspython' is already in Guix. > > linkchecker is using a modified version of dnspython and miniboa. So, I > don't think it will be easy. For a list of modifications, look at > https://github.com/wummel/linkchecker/blob/master/third_party/dnspython/changelog.txt > and https://github.com/wummel/linkchecker/blob/master/third_party/miniboa-r42/CHANGES.txt OK, thanks for checking. >> Also, since GPL2+ is stricter than the other licenses, the program as a >> whole is effectively GPL2+, so we don't really need to mention those >> one-off source files in the license field (but comments are great). > > But, we generally don't hide this information from the user, right? Many > Guix packages have licenses of even single files mentioned in the > `license' field. Do you still think I should remove them? I don't know :-) Licensing is a tricky topic. The GPL is rather explicit in that it covers the "program as a whole". If we treat individual parts differently, it may be misleading to the end user. OTOH, the GPL permits using those source files individually under their own terms. Perhaps the most practical solution would be to add a "supplementary licenses" interface... I am not a lawyer, so please use your own judgement. No strong opinion either way. :-) >> Not sure about the 3rd party bundles though, since they probably don't >> depend on anything from the GPL2+ distribution. If they are installed, >> I guess we should mention them with a FIXME. > > I've added a FIXME. > > I'm attaching a new patch with the discussed changes. Do let me know if > everything looks good. LGTM! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmfEDgACgkQoqBt8qM6 VPp6OQgAoBMhWbXcmNy7rFU7AM/cT4ohOMjQu+8fh7x/3xnzPmwFkzn+r8J6E46H 8hdWByvHnprNBj8NhIlRi/E4oLe3WF6Gl28DnVq7zNI9QYaYldKPl3VdVpU1ZVbN YKiLSpGiD85b9cSijsr30880qone0qWeSpeoAPqqCBIM9J4BxBU5zwviB8w4TP1D 59yZueXCZgodiGjm9tJITuwjgGyl6o+wa8Csyby/Qgll0nFyhaoIEPHB33+cwuZ6 RcUTwWPDjAUQr/WqPzwAO/hZc7GSwoUgK/mcfg5i3U/O71mKq470+tc4l/Am1dhr 0AQPq3XVhMcQmVhbYuwljgrvQ3nmjA== =ex0t -----END PGP SIGNATURE----- --=-=-=--