From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49666)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dwkCv-0001NS-HN
	for guix-patches@gnu.org; Tue, 26 Sep 2017 03:23:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dwkCs-0007PO-Bu
	for guix-patches@gnu.org; Tue, 26 Sep 2017 03:23:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:50886)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dwkCs-0007PF-8R
	for guix-patches@gnu.org; Tue, 26 Sep 2017 03:23:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dwkCs-0003N2-3U
	for guix-patches@gnu.org; Tue, 26 Sep 2017 03:23:02 -0400
Subject: [bug#28421] [PATCH] gnu: Add uim, uim-gtk and uim-qt.
Resent-Message-ID: <handler.28421.B28421.150641055812909@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <97554f2b.ADkAADNjyywAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZyciA@mailjet.com>
Date: Tue, 26 Sep 2017 09:22:26 +0200
In-Reply-To: <97554f2b.ADkAADNjyywAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZyciA@mailjet.com>
	(Arun Isaac's message of "Tue, 26 Sep 2017 08:53:59 +0530")
Message-ID: <87poad3owd.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 28421@debbugs.gnu.org

Hi Arun,

Arun Isaac <arunisaac@systemreboot.net> skribis:

> * gnu/packages/xorg.scm (uim, uim-gtk, uim-qt): New variables.

[...]

> +    (home-page "https://github.com/uim/uim")
> +    (synopsis "Multilingual input method framework")
> +    (description "uim is a multilingual input method library and environ=
ment.
> +It provides a simple, easily extensible and high code-quality input meth=
od
> +development platform, and useful input method environment for users of d=
esktop
> +and embedded platforms.")
> +    (license (list license:lgpl2.1+ ; scm/py.scm, pixmaps/*.{svg,png} (s=
ee pixmaps/README)
> +                   license:gpl2+ ; scm/pinyin-big5.scm
> +                   license:gpl3+ ; scm/elatin-rules.cm
> +                   license:public-domain ; scm/input-parse.scm, scm/matc=
h.scm
> +                   ;; gtk2/toolbar/eggtrayicon.{ch},
> +                   ;; qt3/chardict/kseparator.{cpp,h},
> +                   ;; qt3/pref/kseparator.{cpp,h}
> +                   license:lgpl2.0+
> +                   ;; pixmaps/*.{svg,png} (see pixmaps/README),
> +                   ;; all other files
> +                   license:bsd-3))))
> +
> +(define-public uim-gtk
> +  (package
> +    (inherit uim)
> +    (name "uim-gtk")
> +    (inputs
> +     `(("gtk" ,gtk+)
> +       ("gtk" ,gtk+-2)
> +       ,@(package-inputs uim)))
> +    (synopsis "uim built with GTK+ support")
> +    (description "This package contains uim built with GTK+ support.")))

What about =E2=80=9CMultilingual input method framework (GTK+ support)=E2=
=80=9D for the
synopsis, and leaving the description unchanged?

> +    (synopsis "uim built with Qt support")
> +    (description "This package contains uim built with Qt support.")))

Likewise here.

Otherwise LGTM.  Feel free to push with a change along these lines if
that=E2=80=99s fine with you.

Thanks for patiently working on this!

Ludo=E2=80=99.