From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57050)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e6VuB-0001ib-IU
	for guix-patches@gnu.org; Mon, 23 Oct 2017 02:08:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e6Vu6-0000Yy-JM
	for guix-patches@gnu.org; Mon, 23 Oct 2017 02:08:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:47846)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1e6Vu6-0000Yq-GD
	for guix-patches@gnu.org; Mon, 23 Oct 2017 02:08:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e6Vu6-0005Z2-Aj
	for guix-patches@gnu.org; Mon, 23 Oct 2017 02:08:02 -0400
Subject: [bug#28913] [PATCH 2/2] gnu: Add criu.
Resent-Message-ID: <handler.28913.B28913.150873886521360@debbugs.gnu.org>
References: <20171021005556.28993-1-rekado@elephly.net>
	<20171021005556.28993-2-rekado@elephly.net> <87h8uqyfgv.fsf@gnu.org>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <87h8uqyfgv.fsf@gnu.org>
Date: Mon, 23 Oct 2017 08:07:30 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Message-ID: <87po9etn19.fsf@elephly.net>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 28913@debbugs.gnu.org


Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> * gnu/packages/virtualization.scm (criu): New variable.
>
> [...]
>
>> +         (replace 'configure
>> +           (lambda* (#:key inputs #:allow-other-keys)
>> +             ;; The includes for libnl are located in a sub-directory.
>> +             (setenv "C_INCLUDE_PATH"
>> +                     (string-append (assoc-ref inputs "libnl")
>> +                                    "/include/libnl3:"
>> +                                    (getenv "C_INCLUDE_PATH")))
>
> And there=E2=80=99s no libnet.pc or similar to provide the right -I flag?

There is a libnl-3.0.pc file with these contents:

--8<---------------cut here---------------start------------->8---
prefix=3D/gnu/store/qyr5m7c21a4myx5421m90yxkxav2qij7-libnl-3.4.0
exec_prefix=3D${prefix}
libdir=3D${exec_prefix}/lib
includedir=3D${prefix}/include

Name: libnl
Description: Convenience library for netlink sockets
Version: 3.4.0
Libs: -L${libdir} -lnl-3
Cflags: -I${includedir}/libnl3
--8<---------------cut here---------------end--------------->8---

That=E2=80=99s not enough, though, to find header files included by other l=
ibnl
headers.  Without the setenv snippet above compilation fails with this
error:

--8<---------------cut here---------------start------------->8---
In file included from criu/libnetlink.c:5:0:
/gnu/store/qyr5m7c21a4myx5421m90yxkxav2qij7-libnl-3.4.0/include/libnl3/netl=
ink/attr.h:15:29: fatal error: netlink/netlink.h: No such file or directory
compilation terminated.
--8<---------------cut here---------------end--------------->8---

>> +    (synopsis "Checkpoint and restore in userspace")
>
> =E2=80=9Cuser space=E2=80=9D (two words)?

Okay. Thanks for reviewing these patches!

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net