From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#29186: building guile-emacs fails: required libaries not found:
	libjpeg
Date: Tue, 14 Nov 2017 23:09:31 +0100
Message-ID: <87po8kldgk.fsf@gnu.org>
References: <87po8vm4iv.fsf@gnu.org> <874lq6hbxn.fsf@netris.org>
	<87h8u6m311.fsf@gnu.org> <878tfhlxia.fsf@gnu.org>
	<20171108101226.GD1815@macbook41> <87k1z0hlpr.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39398)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eEjPB-0008AQ-JS
	for bug-guix@gnu.org; Tue, 14 Nov 2017 17:10:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eEjP8-0005KE-EH
	for bug-guix@gnu.org; Tue, 14 Nov 2017 17:10:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:60253)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eEjP8-0005K4-AG
	for bug-guix@gnu.org; Tue, 14 Nov 2017 17:10:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eEjP7-0004m8-SO
	for bug-guix@gnu.org; Tue, 14 Nov 2017 17:10:01 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.29186.B29186.151069737918322@debbugs.gnu.org>
In-Reply-To: <87k1z0hlpr.fsf@gnu.org> (Jan Nieuwenhuizen's message of "Wed, 08
	Nov 2017 15:46:40 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: 29186@debbugs.gnu.org

Hello,

Jan Nieuwenhuizen <janneke@gnu.org> skribis:

> Efraim Flashner writes:
>
>>> +           (add-before 'configure 'setenv
>>> +             (lambda _
>>> +               (setenv "CFLAGS" "-g")))
>>>             (add-after 'unpack 'autogen
>>>                        (lambda _
>>>                          (zero? (system* "sh" "autogen.sh"))))))))))
>>
>> Couldn't this be a make-flag or a configure-flag?
>
> Yes, as a configure flags also works.  However, I tracked down the
> segfault, backported a patch and and now it builds with -O2.
>
> New patch attached.

Great that you found out!

>>From f6633adf4c5ceee3a63da9a3909a94c22f55b68a Mon Sep 17 00:00:00 2001
> From: Jan Nieuwenhuizen <janneke@gnu.org>
> Date: Tue, 7 Nov 2017 08:08:21 +0100
> Subject: [PATCH] gnu: guile-emacs: Resurrect, fixes #29186.
>
> * gnu/packages/patches/guile-emacs-fix-configure.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.
> * gnu/packages/emacs.scm (guile-emacs): Use it.  Add workaround for src/d=
eps
> dir creation.  Fixes #29186.

I=E2=80=99m fine with this patch.  I=E2=80=99m a bit concerned about the ri=
sk of
accumulating patches that should really be in guile-emacs proper,
though.  IMO it would be better if this patch were pushed to
guile-emacs, or if an alternate guile-emacs repo were set up if the
current one is inactive.  If that=E2=80=99s too cumbersome though, feel fre=
e to
push this patch!

Thanks,
Ludo=E2=80=99.