From: ludo@gnu.org (Ludovic Courtès)
To: guix-devel@gnu.org, Rutger Helling <rhelling@mykolab.com>
Subject: Re: 01/01: gnu: qemu: Enable Samba support.
Date: Wed, 27 Dec 2017 13:04:09 +0100 [thread overview]
Message-ID: <87po704bt2.fsf@gnu.org> (raw)
In-Reply-To: <20171227092650.69D7B204F7@vcs0.savannah.gnu.org> (Rutger Helling's message of "Wed, 27 Dec 2017 04:26:50 -0500 (EST)")
Hello,
rhelling@mykolab.com (Rutger Helling) skribis:
> commit 84276503059d46c0a42240f8770f59090614d863
> Author: Rutger Helling <rhelling@mykolab.com>
> Date: Wed Dec 27 10:09:26 2017 +0100
>
> gnu: qemu: Enable Samba support.
>
> * gnu/packages/virtualization.scm (qemu)[arguments]: Change #:configure-flags to
> a list, add --smbd flag.
> [inputs]: Add samba.
[...]
> + #:configure-flags (list "--enable-usb-redir" "--enable-opengl"
> + (string-append "--smbd="
> + (assoc-ref %build-inputs "samba")
> + "/sbin/smbd"))
For the record, we removed the dependency on Samba long ago (commit
b344c505f4dff2ecbe981f0a0a3c3d67b222dcca), largely because Samba is a
huge dependency:
--8<---------------cut here---------------start------------->8---
$ guix size qemu | tail -1
total: 817.4 MiB
$ guix size qemu samba | tail -1
total: 1176.0 MiB
--8<---------------cut here---------------end--------------->8---
As it stands I’d still be in favor of not having the default ‘qemu’
depend on Samba.
Perhaps one solution would be to change the ‘exec’ call that invokes
‘smbd’ to ‘execlp’ (or similar) so that ‘smbd’ is search for in $PATH.
That way, if the user installs Samba, then support is available,
otherwise it’s missing.
WDYT?
Thanks,
Ludo’.
next parent reply other threads:[~2017-12-27 12:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171227092649.22335.79799@vcs0.savannah.gnu.org>
[not found] ` <20171227092650.69D7B204F7@vcs0.savannah.gnu.org>
2017-12-27 12:04 ` Ludovic Courtès [this message]
2017-12-27 13:23 ` 01/01: gnu: qemu: Enable Samba support Rutger Helling
2017-12-27 20:59 ` Rutger Helling
2017-12-27 22:53 ` Mark H Weaver
2017-12-27 22:56 ` Rutger Helling
2017-12-27 23:41 ` Maxim Cournoyer
2017-12-28 5:46 ` Rutger Helling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po704bt2.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=rhelling@mykolab.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.