From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewa4b-0007aH-Hj for guix-patches@gnu.org; Thu, 15 Mar 2018 17:06:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewa4Y-00061s-Bx for guix-patches@gnu.org; Thu, 15 Mar 2018 17:06:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55798) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ewa4Y-000617-8C for guix-patches@gnu.org; Thu, 15 Mar 2018 17:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ewa4Y-0002zg-0G for guix-patches@gnu.org; Thu, 15 Mar 2018 17:06:02 -0400 Subject: [bug#30801] [PATCH 0/1] Add opencv Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180313175809.7d782c1a@alma-ubu> Date: Thu, 15 Mar 2018 22:04:54 +0100 In-Reply-To: <20180313175809.7d782c1a@alma-ubu> ("=?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?="'s message of "Tue, 13 Mar 2018 17:58:09 +0100") Message-ID: <87po45rqx5.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Cc: 30801@debbugs.gnu.org Hi Bj=C3=B6rn, Bj=C3=B6rn H=C3=B6fling skribis: > The test suite consists of an extra package, weighting 465MB > compressed. It runs very well. I think the size is worth it. It > consists of proprietary things (i.e. lena.jpg). As far as I understand, > that is OK, if it doesn't get in the final src/bin store output. Right? As a rule of thumb, there should not be non-free stuff in the derivation graph. If there=E2=80=99s non-free software, that=E2=80=99s not OK, even if it doe= sn=E2=80=99t show up in the output. If it=E2=80=99s =E2=80=9Cjust=E2=80=9D data (pictures) that are non-free, t= hat=E2=80=99s OK per the FSDG: . If we could replace it with a free variant, I think we should clearly encourage it, but lena.jpg is hardly replaceable in this context (I=E2=80= =99d hope it weren=E2=80=99t around for what it tells about CS, but that=E2=80= =99s another story=E2=80=A6). > CPU-optimization: I hope I have done everything right. Reading the > article from Guix HPC a second time helped a lot. So now it should be > compiled with SSE2/NEON being the minimum required instruction set, and > dispatches to other ISAs where available. Great. > Size: Currently I load a bunch of dependencies in and have one > big package as output. guix size is 1.1 GiB. I slightly have the > feeling someone could ask to split it in several outputs. Though having > one big output was the easiest thing first and I don't know how one > would handle inter-dependencies between the different outputs. 1.1G is a bit too much IMO, indeed. :-) How much is OpenCV itself? If OpenCV itself is big, it would be nice to look at what=E2=80=99s taking up space in there with =E2=80=98du=E2=80=99. = For instance, if there are .a files, we might want to not build them and keep only shared objects. Splitting in separate outputs may or may not make sense. If there are examples or large pieces of HTML doc, introducing a =E2=80=9Cdoc=E2=80=9D a= nd/or an =E2=80=9Cexamples=E2=80=9D output may help. Likewise, if there are binarie= s that depend on more stuff that the library itself, introducing a =E2=80=9Clib=E2=80=9D = output might be a good idea. Could you take a look? Nitpick: > + (synopsis "Computer Vision Library") No need to capitalize. > + (description "OpenCV (Open Source Computer Vision) is a library aime= d at I=E2=80=99d remove the parenthetic part. > +real-time computer vision, including several hundred computer > +vision algorithms.") Bonus points if you can expound a little bit, without just listing those algorithms though. ;-) Apart from that the patch looks very polished and that=E2=80=99s a pleasure= to review! Thanks, Ludo=E2=80=99.