[bug#31934] [PATCH] Fix ALSA_PLUGIN_DIR usage

[bug#31934] [PATCH] Fix ALSA_PLUGIN_DIR usage

[Julien Lepiller]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

Hi, this patch fixes an issue with the patch for alsa-lib and defines a 
search-path rather than a native-search-path. In order to make the 
alsa-service work properly, you still need to have alsa-lib and 
alsa-plugins:pulseaudio in the same profile, and point ALSA_PLUGIN_DIR 
to $PROFILE/lib/alsa-lib.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-alsa-lib-Fix-ALSA_PLUGIN_DIR-usage.patch --]
[-- Type: text/x-diff; name=0001-gnu-alsa-lib-Fix-ALSA_PLUGIN_DIR-usage.patch, Size: 3159 bytes --]

From c63867eb51f1464207de950de4d8394971c7ec5f Mon Sep 17 00:00:00 2001
From: Julien Lepiller <julien@lepiller.eu>
Date: Fri, 22 Jun 2018 13:52:18 +0200
Subject: [PATCH] gnu: alsa-lib: Fix ALSA_PLUGIN_DIR usage.

* gnu/packages/linux.scm (native-search-paths): Use search-paths
instead.
* gnu/packages/patches/alsa-lib-add-environment-variable.patch: Use
computed plugdir instead of default ALSA_PLUGIN_DIR.
---
 gnu/packages/linux.scm                              |  2 +-
 .../patches/alsa-lib-add-environment-variable.patch | 21 ++++++++++++++-------
 2 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 7e81f6387..b86dfdf80 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -983,7 +983,7 @@ intercept and print the system calls executed by the program.")
                "096pwrnhj36yndldvs2pj4r871zhcgisks0is78f1jkjn9sd4b2z"))
              (patches (search-patches "alsa-lib-add-environment-variable.patch"))))
     (build-system gnu-build-system)
-    (native-search-paths
+    (search-paths
      (list (search-path-specification
              (variable "ALSA_PLUGIN_DIR")
              (file-type 'regular)
diff --git a/gnu/packages/patches/alsa-lib-add-environment-variable.patch b/gnu/packages/patches/alsa-lib-add-environment-variable.patch
index a468a7fc4..9d122079e 100644
--- a/gnu/packages/patches/alsa-lib-add-environment-variable.patch
+++ b/gnu/packages/patches/alsa-lib-add-environment-variable.patch
@@ -1,21 +1,21 @@
-From 1822fb453128a1b5de93b4c590cd272d6488a077 Mon Sep 17 00:00:00 2001
+From 51523b7d546ade002b0bc999b2e01f9593e8576d Mon Sep 17 00:00:00 2001
 From: Julien Lepiller <julien@lepiller.eu>
-Date: Fri, 25 May 2018 19:26:58 +0200
+Date: Fri, 22 Jun 2018 13:50:45 +0200
 Subject: [PATCH] Add support for a ALSA_PLUGIN_DIR environment variable.
 
 If it is not set, default to previous behavior.
 ---
- src/control/control.c |  6 +++++-
+ src/control/control.c |  8 ++++++--
  src/dlmisc.c          |  9 +++++++--
  src/pcm/pcm.c         |  9 +++++++--
  src/pcm/pcm_rate.c    | 13 +++++++++----
- 4 files changed, 28 insertions(+), 9 deletions(-)
+ 4 files changed, 29 insertions(+), 10 deletions(-)
 
 diff --git a/src/control/control.c b/src/control/control.c
-index 11f7815..9dba7dd 100644
+index 11f7815..920b1af 100644
 --- a/src/control/control.c
 +++ b/src/control/control.c
-@@ -1331,7 +1331,11 @@ static int snd_ctl_open_conf(snd_ctl_t **ctlp, const char *name,
+@@ -1331,13 +1331,17 @@ static int snd_ctl_open_conf(snd_ctl_t **ctlp, const char *name,
  			build_in++;
  		}
  		if (*build_in == NULL) {
@@ -28,6 +28,13 @@ index 11f7815..9dba7dd 100644
  			if (buf1 == NULL) {
  				err = -ENOMEM;
  				goto _err;
+ 			}
+ 			lib = buf1;
+-			sprintf(buf1, "%s/libasound_module_ctl_%s.so", ALSA_PLUGIN_DIR, str);
++			sprintf(buf1, "%s/libasound_module_ctl_%s.so", plugdir, str);
+ 		}
+ 	}
+ #ifndef PIC
 diff --git a/src/dlmisc.c b/src/dlmisc.c
 index 3757d33..92aa864 100644
 --- a/src/dlmisc.c
@@ -106,5 +113,5 @@ index 4e0c7ca..8694a38 100644
  
  	rate->rate_min = SND_PCM_PLUGIN_RATE_MIN;
 -- 
-2.17.0
+2.14.4
 
-- 
2.14.4

[bug#31934] [PATCH] Fix ALSA_PLUGIN_DIR usage

[Ludovic Courtès]

Hello,

Julien Lepiller <julien@lepiller.eu> skribis:

> Hi, this patch fixes an issue with the patch for alsa-lib and defines
> a search-path rather than a native-search-path. In order to make the
> alsa-service work properly, you still need to have alsa-lib and
> alsa-plugins:pulseaudio in the same profile, and point ALSA_PLUGIN_DIR
> to $PROFILE/lib/alsa-lib.

Could you clarify which issue this fixes?

Also, I think you really want ‘native-search-paths’ and not
‘search-paths’.  The latter is meant to be used by things like
cross-compilers.

Thanks,
Ludo’.

[bug#31934] [PATCH] Fix ALSA_PLUGIN_DIR usage

[Julien Lepiller]

Le Fri, 22 Jun 2018 21:54:45 +0200,
ludo@gnu.org (Ludovic Courtès) a écrit :

> Could you clarify which issue this fixes?
> 
> Also, I think you really want ‘native-search-paths’ and not
> ‘search-paths’.  The latter is meant to be used by things like
> cross-compilers.
> 
> Thanks,
> Ludo’.

The issue was that a part of the code was only partially patched. It
looked like:

plugdir = ALSA_PLUGIN_DIR;
envplugdir = getenv("ALSA_PLUGIN_DIR");
if(envplugdir != NULL)
  plugdir = envplugdir;
...
sofile = malloc(sizeof(plugdir) + ...);
...
sprintf(sofile, "%s/whatever.so", ALSA_PLUGIN_DIR);

If at compilation time ALSA_PLUGIN_DIR is bigger than the runtime
$ALSA_PLUGIN_DIR, we are in trouble: alsa-lib will crash because of a
buffer overflow. Otherwise, it just didn't care about $ALSA_PLUGIN_DIR.
The native-search-paths vs search-paths is a bit confusing... I need to
read the manual more carefully I guess.

[bug#31934] [PATCH] Fix ALSA_PLUGIN_DIR usage

[Ludovic Courtès]

Julien Lepiller <julien@lepiller.eu> skribis:

> Le Fri, 22 Jun 2018 21:54:45 +0200,
> ludo@gnu.org (Ludovic Courtès) a écrit :
>
>> Could you clarify which issue this fixes?
>> 
>> Also, I think you really want ‘native-search-paths’ and not
>> ‘search-paths’.  The latter is meant to be used by things like
>> cross-compilers.
>> 
>> Thanks,
>> Ludo’.
>
> The issue was that a part of the code was only partially patched. It
> looked like:
>
> plugdir = ALSA_PLUGIN_DIR;
> envplugdir = getenv("ALSA_PLUGIN_DIR");
> if(envplugdir != NULL)
>   plugdir = envplugdir;
> ...
> sofile = malloc(sizeof(plugdir) + ...);
> ...
> sprintf(sofile, "%s/whatever.so", ALSA_PLUGIN_DIR);
>
> If at compilation time ALSA_PLUGIN_DIR is bigger than the runtime
> $ALSA_PLUGIN_DIR, we are in trouble: alsa-lib will crash because of a
> buffer overflow. Otherwise, it just didn't care about $ALSA_PLUGIN_DIR.

Alright, so the patch update can definitely go in!

> The native-search-paths vs search-paths is a bit confusing... I need to
> read the manual more carefully I guess.

The manual doesn’t say much about this, so you have a good excuse.

But anyway, that change is surely not necessary.

Thanks,
Ludo’.

[bug#31934] [PATCH] Fix ALSA_PLUGIN_DIR usage

[宋文武]

Julien Lepiller <julien@lepiller.eu> writes:

> Hi, this patch fixes an issue with the patch for alsa-lib and defines
> a search-path rather than a native-search-path. In order to make the
> alsa-service work properly, you still need to have alsa-lib and
> alsa-plugins:pulseaudio in the same profile, and point ALSA_PLUGIN_DIR
> to $PROFILE/lib/alsa-lib.

Hello, after some hours of searching...  I found that we can use the
'lib' option in 'pcm_type' and 'ctl_type' to specify the library path
for alsa plugins, e.g:

--8<---------------cut here---------------start------------->8---
# Use PulseAudio by default
pcm_type.pulse {
  lib "/gnu/store/icvba55494j4vxb7yp97iya1h6g1l30h-alsa-plugins-1.1.6-pulseaudio/lib/alsa-lib/libasound_module_pcm_pulse.so"
}

ctl_type.pulse {
  lib "/gnu/store/icvba55494j4vxb7yp97iya1h6g1l30h-alsa-plugins-1.1.6-pulseaudio/lib/alsa-lib/libasound_module_ctl_pulse.so"
}

pcm.!default {
  type pulse
  fallback "sysdefault"
  hint {
    show on
    description "Default ALSA Output (currently PulseAudio Sound Server)"
  }
}

ctl.!default {
  type pulse
  fallback "sysdefault"
}
--8<---------------cut here---------------end--------------->8---

So I think we can make our 'alsa-service' do this, instead of patching
alsa-lib for 'ALSA_PLUGIN_DIR'.  We could document it in the manual, so
that a user wanting to use other alsa plugins get a hint to add:
  'lib "/home/xxx/.guix-profile/lib/alsa-lib/libasound_xxx.so"'
in '~/.asoundrc'.  How's this sound?


Also, NixOS did this actually, and they went far to support running
32-bit alsa applications with 64-bit pulseaudio:

https://github.com/NixOS/nixpkgs/commit/0c8ad65560fa1df07ea7b7937e02b44b1ce2b498

I think we don't need this now...

[bug#31934] [PATCH] services: sound: Properly handle alsa-plugins.

[Oleg Pykhalov]

[-- Attachment #1.1: Type: text/plain, Size: 547 bytes --]

Hello,

iyzsong@member.fsf.org (宋文武) writes:

> Julien Lepiller <julien@lepiller.eu> writes:

[…]

> Hello, after some hours of searching...  I found that we can use the
> 'lib' option in 'pcm_type' and 'ctl_type' to specify the library path
> for alsa plugins, e.g:

Thats a nice hack :-)  Thank you for working on this.

[…]

> So I think we can make our 'alsa-service' do this, instead of patching
> alsa-lib for 'ALSA_PLUGIN_DIR'.

Done.  Here is a patch which I tested on my machine by ‘system reconfigure’:

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: services: sound: Properly handle alsa-plugins. --]
[-- Type: text/x-patch, Size: 3369 bytes --]

From 22186e76d991a47e7057d1abe23af02b52f8153b Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Sun, 24 Jun 2018 13:18:53 +0300
Subject: [PATCH] services: sound: Properly handle alsa-plugins.

* gnu/services/sound.scm (<alsa-configuration>)[alsa-plugins]: New field.
(alsa-config-file): Add this.
* doc/guix.texi (Sound Services): Document this.
---
 doc/guix.texi          |  3 +++
 gnu/services/sound.scm | 31 +++++++++++++++++++++++--------
 2 files changed, 26 insertions(+), 8 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 74c10e4bb..e5366ac6b 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -13152,6 +13152,9 @@ See below for details about @code{alsa-configuration}.
 Data type representing the configuration for @code{alsa-service}.
 
 @table @asis
+@item @code{alsa-plugins} (default: @var{alsa-plugins})
+@code{alsa-plugins} package to use.
+
 @item @code{pulseaudio?} (default: @var{#t})
 Whether ALSA applications should transparently be made to use the
 @uref{http://www.pulseaudio.org/, PulseAudio} sound server.
diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm
index 5fe555e8b..2b2cabd7b 100644
--- a/gnu/services/sound.scm
+++ b/gnu/services/sound.scm
@@ -26,6 +26,7 @@
   #:use-module (guix packages)
   #:use-module (guix records)
   #:use-module (guix store)
+  #:use-module (gnu packages linux)
   #:use-module (gnu packages pulseaudio)
   #:use-module (ice-9 match)
   #:export (alsa-configuration
@@ -44,17 +45,31 @@
 
 (define-record-type* <alsa-configuration>
   alsa-configuration make-alsa-configuration alsa-configuration?
+  (alsa-plugins alsa-configuration-alsa-plugins ;<package>
+                (default alsa-plugins))
   (pulseaudio?   alsa-configuration-pulseaudio? ;boolean
                  (default #t))
   (extra-options alsa-configuration-extra-options ;string
                  (default "")))
 
-(define (alsa-config-file config)
-  "Return the ALSA configuration file corresponding to CONFIG."
-  (plain-file "asound.conf"
-              (string-append "# Generated by 'alsa-service'.\n\n"
-                             (if (alsa-configuration-pulseaudio? config)
-                                 "# Use PulseAudio by default
+(define alsa-config-file
+  ;; Return the ALSA configuration file.
+  (match-lambda
+    (($ <alsa-configuration> alsa-plugins pulseaudio? extra-options)
+     (mixed-text-file "asound.conf"
+                      "# Generated by 'alsa-service'.\n\n"
+                      ;; if pulseaudio?
+                      "# Use PulseAudio by default
+pcm_type.pulse {
+  lib " #~(string-append #$alsa-plugins:pulseaudio
+                         "/lib/alsa-lib/libasound_module_pcm_pulse.so") "
+}
+
+ctl_type.pulse {
+  lib " #~(string-append #$alsa-plugins:pulseaudio
+                         "/lib/alsa-lib/libasound_module_ctl_pulse.so") "
+}
+
 pcm.!default {
   type pulse
   fallback \"sysdefault\"
@@ -69,8 +84,8 @@ ctl.!default {
   fallback \"sysdefault\"
 }
 "
-                                 "")
-                             (alsa-configuration-extra-options config))))
+                           ""
+                      extra-options))))
 
 (define (alsa-etc-service config)
   (list `("asound.conf" ,(alsa-config-file config))))
-- 
2.17.1


[-- Attachment #1.3: Type: text/plain, Size: 27 bytes --]


[…]

Thanks,
Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

bug#31591: [bug#31934] [PATCH] services: sound: Properly handle alsa-plugins.

[宋文武]

Oleg Pykhalov <go.wigust@gmail.com> writes:

> Hello,
>
> iyzsong@member.fsf.org (宋文武) writes:
>
>> Julien Lepiller <julien@lepiller.eu> writes:
>
> […]
>
>> Hello, after some hours of searching...  I found that we can use the
>> 'lib' option in 'pcm_type' and 'ctl_type' to specify the library path
>> for alsa plugins, e.g:
>
> Thats a nice hack :-)  Thank you for working on this.
>
> […]
>
>> So I think we can make our 'alsa-service' do this, instead of patching
>> alsa-lib for 'ALSA_PLUGIN_DIR'.
>
> Done.  Here is a patch which I tested on my machine by ‘system reconfigure’:
>

Thank you, I modified it to keep the 'pulseaudio? #f' function, and
pushed :-)

[bug#31934] [PATCH] services: sound: Properly handle alsa-plugins.

[宋文武]

Oleg Pykhalov <go.wigust@gmail.com> writes:

> Hello,
>
> iyzsong@member.fsf.org (宋文武) writes:
>
>> Julien Lepiller <julien@lepiller.eu> writes:
>
> […]
>
>> Hello, after some hours of searching...  I found that we can use the
>> 'lib' option in 'pcm_type' and 'ctl_type' to specify the library path
>> for alsa plugins, e.g:
>
> Thats a nice hack :-)  Thank you for working on this.
>
> […]
>
>> So I think we can make our 'alsa-service' do this, instead of patching
>> alsa-lib for 'ALSA_PLUGIN_DIR'.
>
> Done.  Here is a patch which I tested on my machine by ‘system reconfigure’:
>

Thank you, I modified it to keep the 'pulseaudio? #f' function, and
pushed :-)

[bug#31934] [PATCH] services: sound: Properly handle alsa-plugins.

[Julien Lepiller]

Le 2018-06-25 17:34, iyzsong@member.fsf.org a écrit :
> Oleg Pykhalov <go.wigust@gmail.com> writes:
> 
>> Hello,
>> 
>> iyzsong@member.fsf.org (宋文武) writes:
>> 
>>> Julien Lepiller <julien@lepiller.eu> writes:
>> 
>> […]
>> 
>>> Hello, after some hours of searching...  I found that we can use the
>>> 'lib' option in 'pcm_type' and 'ctl_type' to specify the library path
>>> for alsa plugins, e.g:
>> 
>> Thats a nice hack :-)  Thank you for working on this.
>> 
>> […]
>> 
>>> So I think we can make our 'alsa-service' do this, instead of 
>>> patching
>>> alsa-lib for 'ALSA_PLUGIN_DIR'.
>> 
>> Done.  Here is a patch which I tested on my machine by ‘system 
>> reconfigure’:
>> 
> 
> Thank you, I modified it to keep the 'pulseaudio? #f' function, and
> pushed :-)

So maybe we can drop our ALSA_PLUGIN_DIR patch now?

[bug#31934] [PATCH] services: sound: Properly handle alsa-plugins.

[宋文武]

Julien Lepiller <julien@lepiller.eu> writes:

> Le 2018-06-25 17:34, iyzsong@member.fsf.org a écrit :
>> Oleg Pykhalov <go.wigust@gmail.com> writes:
>>
>>> Hello,
>>>
>>> iyzsong@member.fsf.org (宋文武) writes:
>>>
>>>> Julien Lepiller <julien@lepiller.eu> writes:
>>>
>>> […]
>>>
>>>> Hello, after some hours of searching...  I found that we can use the
>>>> 'lib' option in 'pcm_type' and 'ctl_type' to specify the library path
>>>> for alsa plugins, e.g:
>>>
>>> Thats a nice hack :-)  Thank you for working on this.
>>>
>>> […]
>>>
>>>> So I think we can make our 'alsa-service' do this, instead of
>>>> patching
>>>> alsa-lib for 'ALSA_PLUGIN_DIR'.
>>>
>>> Done.  Here is a patch which I tested on my machine by ‘system
>>> reconfigure’:
>>>
>>
>> Thank you, I modified it to keep the 'pulseaudio? #f' function, and
>> pushed :-)
>
> So maybe we can drop our ALSA_PLUGIN_DIR patch now?

Yes, I think so.  @Ricardo, should we do it in core-updates?

[bug#31934] [PATCH] services: sound: Properly handle alsa-plugins.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1177 bytes --]

iyzsong@member.fsf.org (宋文武) writes:

> Julien Lepiller <julien@lepiller.eu> writes:
>
>> Le 2018-06-25 17:34, iyzsong@member.fsf.org a écrit :
>>> Oleg Pykhalov <go.wigust@gmail.com> writes:
>>>
>>>> Hello,
>>>>
>>>> iyzsong@member.fsf.org (宋文武) writes:
>>>>
>>>>> Julien Lepiller <julien@lepiller.eu> writes:
>>>>
>>>> […]
>>>>
>>>>> Hello, after some hours of searching...  I found that we can use the
>>>>> 'lib' option in 'pcm_type' and 'ctl_type' to specify the library path
>>>>> for alsa plugins, e.g:
>>>>
>>>> Thats a nice hack :-)  Thank you for working on this.
>>>>
>>>> […]
>>>>
>>>>> So I think we can make our 'alsa-service' do this, instead of
>>>>> patching
>>>>> alsa-lib for 'ALSA_PLUGIN_DIR'.
>>>>
>>>> Done.  Here is a patch which I tested on my machine by ‘system
>>>> reconfigure’:
>>>>
>>>
>>> Thank you, I modified it to keep the 'pulseaudio? #f' function, and
>>> pushed :-)
>>
>> So maybe we can drop our ALSA_PLUGIN_DIR patch now?
>
> Yes, I think so.  @Ricardo, should we do it in core-updates?

If you're quick, you can do it on 'staging' which I'll attempt to
re-start during today.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#31934: [PATCH] services: sound: Properly handle alsa-plugins.

[宋文武]

Marius Bakke <mbakke@fastmail.com> writes:

> iyzsong@member.fsf.org (宋文武) writes:
>
>> Julien Lepiller <julien@lepiller.eu> writes:
>>
>>> Le 2018-06-25 17:34, iyzsong@member.fsf.org a écrit :
>>>> Oleg Pykhalov <go.wigust@gmail.com> writes:
>>>>
>>>>> Hello,
>>>>>
>>>>> iyzsong@member.fsf.org (宋文武) writes:
>>>>>
>>>>>> Julien Lepiller <julien@lepiller.eu> writes:
>>>>>
>>>>> […]
>>>>>
>>>>>> Hello, after some hours of searching...  I found that we can use the
>>>>>> 'lib' option in 'pcm_type' and 'ctl_type' to specify the library path
>>>>>> for alsa plugins, e.g:
>>>>>
>>>>> Thats a nice hack :-)  Thank you for working on this.
>>>>>
>>>>> […]
>>>>>
>>>>>> So I think we can make our 'alsa-service' do this, instead of
>>>>>> patching
>>>>>> alsa-lib for 'ALSA_PLUGIN_DIR'.
>>>>>
>>>>> Done.  Here is a patch which I tested on my machine by ‘system
>>>>> reconfigure’:
>>>>>
>>>>
>>>> Thank you, I modified it to keep the 'pulseaudio? #f' function, and
>>>> pushed :-)
>>>
>>> So maybe we can drop our ALSA_PLUGIN_DIR patch now?
>>
>> Yes, I think so.  @Ricardo, should we do it in core-updates?
>
> If you're quick, you can do it on 'staging' which I'll attempt to
> re-start during today.

Done, thanks!

And we can close this patch now...

[bug#31934] [PATCH] services: sound: Properly handle alsa-plugins.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1526 bytes --]

iyzsong@member.fsf.org (宋文武) writes:

> Marius Bakke <mbakke@fastmail.com> writes:
>
>> iyzsong@member.fsf.org (宋文武) writes:
>>
>>> Julien Lepiller <julien@lepiller.eu> writes:
>>>
>>>> Le 2018-06-25 17:34, iyzsong@member.fsf.org a écrit :
>>>>> Oleg Pykhalov <go.wigust@gmail.com> writes:
>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> iyzsong@member.fsf.org (宋文武) writes:
>>>>>>
>>>>>>> Julien Lepiller <julien@lepiller.eu> writes:
>>>>>>
>>>>>> […]
>>>>>>
>>>>>>> Hello, after some hours of searching...  I found that we can use the
>>>>>>> 'lib' option in 'pcm_type' and 'ctl_type' to specify the library path
>>>>>>> for alsa plugins, e.g:
>>>>>>
>>>>>> Thats a nice hack :-)  Thank you for working on this.
>>>>>>
>>>>>> […]
>>>>>>
>>>>>>> So I think we can make our 'alsa-service' do this, instead of
>>>>>>> patching
>>>>>>> alsa-lib for 'ALSA_PLUGIN_DIR'.
>>>>>>
>>>>>> Done.  Here is a patch which I tested on my machine by ‘system
>>>>>> reconfigure’:
>>>>>>
>>>>>
>>>>> Thank you, I modified it to keep the 'pulseaudio? #f' function, and
>>>>> pushed :-)
>>>>
>>>> So maybe we can drop our ALSA_PLUGIN_DIR patch now?
>>>
>>> Yes, I think so.  @Ricardo, should we do it in core-updates?
>>
>> If you're quick, you can do it on 'staging' which I'll attempt to
>> re-start during today.
>
> Done, thanks!

Thanks!  I've spun the Hydra lucky wheel:

https://hydra.gnu.org/jobset/gnu/staging

If we won, the new build jobs will start in about 8 hours.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 483 bytes --]

[bug#31934] [PATCH] services: sound: Properly handle alsa-plugins.

[Ludovic Courtès]

Julien Lepiller <julien@lepiller.eu> skribis:

> So maybe we can drop our ALSA_PLUGIN_DIR patch now?

It may still be useful on foreign distros, no?

Ludo’.