all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 31955@debbugs.gnu.org, "Clément Lassieur" <clement@lassieur.org>,
	"Nils Gillmann" <ng0@n0.is>
Subject: [bug#31955] [PATCH] gnu: rust: support build with glibc-2.27, update to 1.26.2
Date: Sat, 07 Jul 2018 16:53:48 +0200	[thread overview]
Message-ID: <87pnzz85c3.fsf@gnu.org> (raw)
In-Reply-To: <20180707085601.190e55c5@scratchpost.org> (Danny Milosavljevic's message of "Sat, 7 Jul 2018 09:09:01 +0200")

Hello Danny,

To make progress and allow Rust to be used along with glibc 2.27, what
about incorporating Nicolai’s patch (assuming it’s all fine), and
investigating the reproducibility issues separately?

If this plan sounds good to you, please push Nicolai’s patch.

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> in trying to further limit the area where the rust update doesn't build for me, I invoked
>
> $ guix build --rounds=2 -e '(@ (gnu packages rust) rust-1.23)' >RR3 2>&1
> <works fine>
> $ guix build --rounds=2 -e '(@ (gnu packages rust) rust-1.24)' >RR4 2>&1
> <works fine>
> $ guix build --rounds=2 -e '(@ (gnu packages rust) rust-1.25)' >RR5 2>&1
> <reproducibility error>
>
> Furthermore, I've got a locale (?) problem since updating guix which makes the message in
> RR5 say:
>
>   output â of â differs from â from previous round

These format strings in build.cc use curly quotes, which I’ve tried to
avoid in the C++ code base, but this slept through.  Regardless, the
client code in (guix store) is supposed to interpret what the daemon
sends as UTF-8, and then to display it in the current locale encoding
(converting it if necessary.)

Could you try to strace ‘guix build’ to see whether the client receives
a correct string in the first place?

Then we should probably change those curly quotes to straight quotes in
build.cc (curly quotes should be added by the message translations, when
appropriate.)

> │ │ │ -   773: 000000000003bf40  5571 FUNC    LOCAL  DEFAULT   12 _ZN6syntax5visit9walk_expr17h6eaff91d038660deE
> │ │ │ +   773: 000000000003bf40  5572 FUNC    LOCAL  DEFAULT   12 _ZN6syntax5visit9walk_expr17h6eaff91d038660deE

Looks like this particular ‘walk_expr’ method is offset for some reason,
probably causing all the other changes.

Could you diff the two build logs to see if there’s any hint, like the
order in which file names appear on the link command line?

Also, can you make sure the build doesn’t rely on ‘-fprofile-use’ or
similar?

Thanks,
Ludo’.

  reply	other threads:[~2018-07-07 14:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-18 21:34 [bug#31955] [PATCH] gnu: rust: support build with glibc-2.27, update to 1.26.2 Nikolai Merinov
2018-06-27 10:06 ` Jelle Licht
2018-07-02 15:28   ` Ludovic Courtès
2018-07-04  9:31 ` Nils Gillmann
2018-07-04  9:47   ` Clément Lassieur
2018-07-04 12:39     ` Nikolai Merinov
2018-07-04 15:45       ` Danny Milosavljevic
2018-07-04 22:07         ` Nikolai Merinov
2018-07-07  7:09         ` Danny Milosavljevic
2018-07-07 14:53           ` Ludovic Courtès [this message]
2018-07-09 14:23             ` Danny Milosavljevic
2018-07-07 20:13           ` Nikolai Merinov
2018-07-10 15:54             ` Jonathan Brielmaier
2018-07-11  6:06               ` Nils Gillmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnzz85c3.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=31955@debbugs.gnu.org \
    --cc=clement@lassieur.org \
    --cc=dannym@scratchpost.org \
    --cc=ng0@n0.is \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.