From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54979)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fcX3H-00036y-U1
	for guix-patches@gnu.org; Mon, 09 Jul 2018 10:22:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fcX3C-00084W-QR
	for guix-patches@gnu.org; Mon, 09 Jul 2018 10:22:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:44651)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fcX3C-00084P-MQ
	for guix-patches@gnu.org; Mon, 09 Jul 2018 10:22:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fcX3C-0005Un-DZ
	for guix-patches@gnu.org; Mon, 09 Jul 2018 10:22:02 -0400
Subject: [bug#31911] services: Add prometheus-node-exporter-service-type.
Resent-Message-ID: <handler.31911.D31911.153114611021103@debbugs.gnu.org>
References: <20180620125946.7264-1-boskovits@gmail.com>
	<CAE4v=pjd+26rcbsE5=_tv9yD=01VBbz46atabwmvOzi8+7LauA@mail.gmail.com>
	<87sh4s93ai.fsf@lassieur.org>
	<CAE4v=pgwpfDsWxbbx1Gg2d90Hk7F0d5y+xBN8Z7MssnfXneDSA@mail.gmail.com>
From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
In-reply-to: <CAE4v=pgwpfDsWxbbx1Gg2d90Hk7F0d5y+xBN8Z7MssnfXneDSA@mail.gmail.com>
Date: Mon, 09 Jul 2018 16:21:44 +0200
Message-ID: <87pnzw8p6v.fsf@lassieur.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: =?UTF-8?Q?G=C3=A1bor?= Boskovits <boskovits@gmail.com>
Cc: 31911-done@debbugs.gnu.org

G=C3=A1bor Boskovits <boskovits@gmail.com> writes:

> Cl=C3=A9ment Lassieur <clement@lassieur.org> ezt =C3=ADrta (id=C5=91pont:=
 2018. j=C3=BAl. 9.,
> H, 11:17):
>
>> Hi G=C3=A1bor,
>>
>> G=C3=A1bor Boskovits <boskovits@gmail.com> writes:
>>
>> > Pushed to master as a33652ee336ae9a5d2ab5fd54bf2397caec42a0e.
>>
>> > +          (test-assert "prometheus-node-exporter running"
>> > +            (marionette-eval
>> > +             '(begin
>> > +                (use-modules (gnu services herd))
>> > +                (match (start-service 'prometheus-node-exporter)
>> > +                  (#f #f)
>> > +                  (('service response-parts ...)
>> > +                   (match (assq-ref response-parts 'running)
>> > +                     ((pid) (number? pid))))))
>> > +             marionette))
>>
>> The PID check is useless because START-SERVICE will return #f if the
>> service fails to start.  Instead, I'd use:
>>
>>           (test-assert "prometheus-node-exporter running"
>>             (marionette-eval
>>              '(begin
>>                 (use-modules (gnu services herd))
>>                 (start-service 'prometheus-node-exporter))
>>              marionette))
>>
>> This would also make the test more robust to service changes (e.g. it
>> would still work if MAKE-FORKEXEC-CONSTRUCTOR is removed).
>>
>>
> Thanks, I will adjust accordingly. Incidentally the code is almost the sa=
me
> as in hpcguix-web test. Should we also adjust that?

You're welcome :-)  It's not urgent, but in the long term, it would be
good that all similar code is ajusted accordingly.  It's in lots of
other places as well if I remember well.