From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43369)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fdj1K-0005R2-UD
	for guix-patches@gnu.org; Thu, 12 Jul 2018 17:21:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fdj1K-0006xa-53
	for guix-patches@gnu.org; Thu, 12 Jul 2018 17:21:02 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:49517)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fdj1K-0006xI-1B
	for guix-patches@gnu.org; Thu, 12 Jul 2018 17:21:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fdj1J-0006TO-RW
	for guix-patches@gnu.org; Thu, 12 Jul 2018 17:21:01 -0400
Subject: [bug#31965] [PATCH] gnu: Add gaupol.
Resent-Message-ID: <handler.31965.B31965.153143042624824@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180625152249.7654-1-ambrevar@gmail.com>
Date: Thu, 12 Jul 2018 23:20:16 +0200
In-Reply-To: <20180625152249.7654-1-ambrevar@gmail.com> (Pierre Neidhardt's
	message of "Mon, 25 Jun 2018 17:22:49 +0200")
Message-ID: <87pnzsrw1b.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Pierre Neidhardt <ambrevar@gmail.com>
Cc: 31965@debbugs.gnu.org

Hello Pierre!

Pierre Neidhardt <ambrevar@gmail.com> skribis:

> * gnu/packages/video.scm (gaupol): New variable.

[...]

> +         (add-after 'install 'patch-data-dir
> +           ;; Fix some path variables that setup.py seems to garble.
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out")))
> +               (substitute* (string-append out "/lib/python3.6/site-pack=
ages/aeidon/paths.py")

This could break silently the day we switch to Python 3.7.  Instead, I
think you can write:

  (substitute* (find-files out "^paths\\.py$")
    =E2=80=A6)

There=E2=80=99s possibly another issue: if there exists a =E2=80=98paths.py=
c=E2=80=99 file, it
becomes outdated once we=E2=80=99ve modified =E2=80=98paths.py=E2=80=99.

Perhaps we should move this phase before the build phase?

Otherwise LGTM, thanks!

Ludo=E2=80=99.