From: ludo@gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <ambrevar@gmail.com>
Cc: 31965@debbugs.gnu.org
Subject: [bug#31965] [PATCH] gnu: Add gaupol.
Date: Thu, 12 Jul 2018 23:20:16 +0200 [thread overview]
Message-ID: <87pnzsrw1b.fsf@gnu.org> (raw)
In-Reply-To: <20180625152249.7654-1-ambrevar@gmail.com> (Pierre Neidhardt's message of "Mon, 25 Jun 2018 17:22:49 +0200")
Hello Pierre!
Pierre Neidhardt <ambrevar@gmail.com> skribis:
> * gnu/packages/video.scm (gaupol): New variable.
[...]
> + (add-after 'install 'patch-data-dir
> + ;; Fix some path variables that setup.py seems to garble.
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((out (assoc-ref outputs "out")))
> + (substitute* (string-append out "/lib/python3.6/site-packages/aeidon/paths.py")
This could break silently the day we switch to Python 3.7. Instead, I
think you can write:
(substitute* (find-files out "^paths\\.py$")
…)
There’s possibly another issue: if there exists a ‘paths.pyc’ file, it
becomes outdated once we’ve modified ‘paths.py’.
Perhaps we should move this phase before the build phase?
Otherwise LGTM, thanks!
Ludo’.
prev parent reply other threads:[~2018-07-12 21:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 15:22 [bug#31965] [PATCH] gnu: Add gaupol Pierre Neidhardt
2018-06-25 15:27 ` Pierre Neidhardt
2018-07-12 21:21 ` Ludovic Courtès
2018-07-12 21:20 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnzsrw1b.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=31965@debbugs.gnu.org \
--cc=ambrevar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.