From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36775) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffR0N-0004V2-5P for guix-patches@gnu.org; Tue, 17 Jul 2018 10:31:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffR0I-0003pW-9S for guix-patches@gnu.org; Tue, 17 Jul 2018 10:31:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:40597) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ffR0H-0003pD-Rh for guix-patches@gnu.org; Tue, 17 Jul 2018 10:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ffR0H-0006Eo-L2 for guix-patches@gnu.org; Tue, 17 Jul 2018 10:31:01 -0400 Subject: [bug#32186] [PATCH] gnu: Add emacs-rust-mode. Resent-Message-ID: From: Kei Kebreau References: <20180717112438.5228-1-pierre-antoine.rouby@inria.fr> Date: Tue, 17 Jul 2018 10:30:22 -0400 In-Reply-To: <20180717112438.5228-1-pierre-antoine.rouby@inria.fr> (Rouby Pierre-Antoine's message of "Tue, 17 Jul 2018 13:24:38 +0200") Message-ID: <87pnzmylxd.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Rouby Pierre-Antoine Cc: 32186@debbugs.gnu.org --=-=-= Content-Type: text/plain Hello Rouby, > * gnu/packages/emacs.scm: New variable. > --- > gnu/packages/emacs.scm | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm > index c6c7a1df4..68780aea8 100644 > --- a/gnu/packages/emacs.scm > +++ b/gnu/packages/emacs.scm > @@ -11410,3 +11410,33 @@ siblings and friends. This visual overview can also be used to browse your > entries. You can think of entries as nodes in a mind map, or pages in a > wiki.") > (license license:expat))) > + > +(define-public emacs-rust-mode > + (let ((commit "64b4a2450e4d4c47f6307851c9b2598cd2254d68") > + (revision "0")) > + (package > + (name "emacs-rust-mode") > + (version (git-version "0.3.0" revision commit)) > + (source (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/rust-lang/rust-mode") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0pbz36lljgb7bdgx3h3g0pq1nss1kvn8mhk1l3mknsmynd6w4nd8")))) I'm guessing that you chose this snapshot because of the additional bug fixes? If so, please include that information in a comment. > + (build-system emacs-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (replace 'check > + (lambda _ > + (invoke "sh" "run_rust_emacs_tests.sh")))))) > + (home-page "https://github.com/rust-lang/rust-mode") > + (synopsis "Major Emacs mode for editing Rust source code") > + (description > + "This package provide major Emacs mode for editing Rust source code.") Here I would change "provide" to "provides a", as it reads more naturally. > + (license (list license:expat > + license:asl2.0))))) Also, don't forget to add a copyright line at the top of gnu/packages/emacs.scm for yourself! Other than those small things, this patch looks and works fine. Could you send an updated patch? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAltN/X4ACgkQ5qXuPBlG eg0IYQ//d1C9s1M8M65P5AMKqa0BOWe1v2bQsRKAgUZwi1B/DGjAMTtsWqYDFFDu V72Cy6V9Dlx67aZl7cktfs1GLUI9vrCC5tRqIdInFK2/r+oedxlXiB6yr1o84kPz QrVQeaS24bcKCM+SNnpVs/+n6s17t2Tvl2a9pV5xqOq1NmV+afVFtFJATlAcNXKS o2AaH/UwDhUjnBeRVVJ31de7824QDT30Sp+KoypuS6NJQbMqtb5YoxW8+zAdL6hZ +iEQ3z7CgzAiNH594ORhKClApCiiYpV6leipM0HK87BBTuPpbv6JZOjGUWBunzhw mWQv7HqcDIalAldlbdUAXNT/iaHUZtMLCb1ktNGpyhyx2NH4M+mW7aCcDNRUbH5Y TGNEg1HcsUCyEp9MoKGmH0KxGeYDj/1CDiCdN5bhgRnELcuQ2pPowcJtecyB6zp8 azEYTT8uly1zguucyuDB3mVJOizl5zr94+XHIDyCBnpW1zCcNelsmiPzLwuRcKD8 Bzrrhkh3DMAEejAJio+EoRjUzewbRa0OhUc9E8ybAgFbrj6kLfuIKr41TwSsepuE ov1BLXohAdsCcdfVE9thGcr4pBaiWVs4PE660th+9BaHpQNXZFuHnUf7mP1a16sm NKX/KSa6jCk4A9Q8I2+i4MFKtfHq5BeqjT4MqucH5hJSsqCK62o= =5JfQ -----END PGP SIGNATURE----- --=-=-=--