From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fpoms-0000SY-JS for guix-patches@gnu.org; Wed, 15 Aug 2018 01:56:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fpomp-0003dS-5k for guix-patches@gnu.org; Wed, 15 Aug 2018 01:56:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:46252) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fpomo-0003cA-RD for guix-patches@gnu.org; Wed, 15 Aug 2018 01:56:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fpomo-0005Rr-J2 for guix-patches@gnu.org; Wed, 15 Aug 2018 01:56:02 -0400 Subject: [bug#32358] Add pcscd service Resent-Message-ID: From: Chris Marusich References: <87a7q2lqc6.fsf@garuda.local.i-did-not-set--mail-host-address--so-tickle-me> <87zhxu7lr9.fsf@gmail.com> <87sh3jkyqg.fsf@gmail.com> <878t5b6u1r.fsf@lassieur.org> <87ftziybse.fsf@gmail.com> <87600e6xv6.fsf@lassieur.org> Date: Tue, 14 Aug 2018 22:55:30 -0700 In-Reply-To: <87600e6xv6.fsf@lassieur.org> ("=?UTF-8?Q?Cl=C3=A9ment?= Lassieur"'s message of "Mon, 13 Aug 2018 18:21:33 +0200") Message-ID: <87pnyk6unh.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Cc: 32358@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Cl=C3=A9ment and Arun, Cl=C3=A9ment, your explanation makes sense. With that information, I now understand why it isn't necessary to use make-forkexec-constructor in this case. Thank you for taking the time to explain it in detail! Arun Isaac writes: > I have finished work on the tests too. Please find attached the updated > patch. Awesome! > +(define* (run-pcscd-test) > + "Run tests of 'pcscd-service-type'." > + (define os > + (marionette-operating-system > + %pcscd-os > + #:imported-modules '((gnu services herd)))) If you use the #:requirements keyword argument to marionette-operating-system, you can guarantee that the marionette service will start up after the pcscd service. This would be good in order to avoid the possibility that you might marionette-eval something before the pcscd service is started. With that small change, if the system test passes, I think this is good to go to master. Thank you for taking the time to work on this and iterate through the feedback! =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAltzwFIACgkQ3UCaFdgi Rp2eQhAAoBRE4PaKOd5IC1hvP35pRePHdRcB/wrx4x0+pfSfCffJXOmcd8AVP3ZX RQ/1OBcea9PQSyZNPV1WkoQ2h+H8aR+rxqjexUXjSWzV6tSeKoc1++2YB8ADIhwm Ff7drraYEN4PknHRhuJ0PGTN09m+FkE1/nh+9IZqrMeGToEjAqFH+W2hAvpqVQW/ iWBF2uvVo+SKtszq4S/VWF8GQDTTJKkSpBBdgp51YxThTqfcwEpd7LmlmkaDD+Pc t0/C4cCKt8i5UcXjA8QKTeN1NP7uvaNDIByTMlLIsChrMskbzYk2j0G2Gs/AZ0Mz AtPsLzNYrVC3Fv2bURawfHdu0XyPW0ygphJcNiQRji/r675k91ZHVMi8ErediYh4 UFA4XYyokdK8AflIFVhawm0CMfsnHm3BimGcEmbICA9jsSizn3/F5pWtN7emnQ+F jSIz2ExsBD4jguq5g4g0DLBQc9mIRhBe9B0CHXSJOiVh/anhhHJucczHFEasFRpD qg/ew45ZqEVpeS5ypi0YsiHwDWtO8ETywWHqM3l9oeN7rIrnXCYgFmFkMZuJTVC4 EGRqej7zkqYPzHHS34f1huFovaHG9jzq0SKhYVvV5closr8rHy8d/MGW9kjJTp/w AQ61pmE2tZUM2hO2XXFOrsbt78SR56oS+9nhhoqCi1P9akMUvgE= =fFRR -----END PGP SIGNATURE----- --=-=-=--