all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Chris Marusich <cmmarusich@gmail.com>
To: "Clément Lassieur" <clement@lassieur.org>
Cc: 32358@debbugs.gnu.org
Subject: [bug#32358] Add pcscd service
Date: Tue, 14 Aug 2018 22:55:30 -0700	[thread overview]
Message-ID: <87pnyk6unh.fsf@gmail.com> (raw)
In-Reply-To: <87600e6xv6.fsf@lassieur.org> ("Clément Lassieur"'s message of "Mon, 13 Aug 2018 18:21:33 +0200")

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

Hi Clément and Arun,

Clément, your explanation makes sense.  With that information, I now
understand why it isn't necessary to use make-forkexec-constructor in
this case.  Thank you for taking the time to explain it in detail!

Arun Isaac <arunisaac@systemreboot.net> writes:

> I have finished work on the tests too. Please find attached the updated
> patch.

Awesome!

> +(define* (run-pcscd-test)
> +  "Run tests of 'pcscd-service-type'."
> +  (define os
> +    (marionette-operating-system
> +     %pcscd-os
> +     #:imported-modules '((gnu services herd))))

If you use the #:requirements keyword argument to
marionette-operating-system, you can guarantee that the marionette
service will start up after the pcscd service.  This would be good in
order to avoid the possibility that you might marionette-eval something
before the pcscd service is started.

With that small change, if the system test passes, I think this is good
to go to master.  Thank you for taking the time to work on this and
iterate through the feedback!

-- 
Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  parent reply	other threads:[~2018-08-15  5:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-03 10:23 [bug#32358] Add pcscd service Arun Isaac
2018-08-04  4:15 ` Chris Marusich
2018-08-04 12:42   ` Arun Isaac
2018-08-09 14:25     ` Arun Isaac
2018-08-10  6:56       ` Chris Marusich
2018-08-12  8:25         ` Arun Isaac
2018-08-13 21:17           ` Arun Isaac
2018-08-13 21:24             ` Arun Isaac
2018-08-14  9:00               ` Arun Isaac
     [not found]         ` <b19c2167.AL4AABKe2YsAAAAAAAAAAAQxnJwAAAACwQwAAAAAAAW9WABbb-8t@mailjet.com>
2018-08-12 22:26           ` Chris Marusich
2018-08-12 23:31             ` Clément Lassieur
2018-08-13  7:18               ` Chris Marusich
2018-08-13 16:21                 ` Clément Lassieur
2018-08-13 16:36                   ` Clément Lassieur
2018-08-15  5:55                   ` Chris Marusich [this message]
2018-08-15 19:00                     ` Clément Lassieur
2018-08-15 21:24                       ` bug#32358: " Arun Isaac
2018-08-06 14:36 ` [bug#32358] About commit "Avoid assertion violations in maybe_produce_line_number" Kaushal Modi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnyk6unh.fsf@gmail.com \
    --to=cmmarusich@gmail.com \
    --cc=32358@debbugs.gnu.org \
    --cc=clement@lassieur.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.