From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Othacehe Subject: Re: Merging =?utf-8?Q?=E2=80=98wip-newt-installer=E2=80=99?= in master? Date: Fri, 23 Nov 2018 23:48:52 +0900 Message-ID: <87pnuv26jv.fsf@gmail.com> References: <87lg6sejwa.fsf@gmail.com> <87wopd88hq.fsf@gmail.com> <877ehcsocq.fsf@gnu.org> <87bm6oxsyf.fsf@gmail.com> <87a7m7yhu5.fsf@gmail.com> <878t1rygfu.fsf@gmail.com> <877ehbydmz.fsf@gmail.com> <87sgzykmyx.fsf@gnu.org> <877eh9245u.fsf@gmail.com> <87efbgx0p0.fsf@gnu.org> <87sgzw5ylb.fsf@gmail.com> <87zhu1cw4p.fsf_-_@gnu.org> <875zwp17od.fsf@gmail.com> <87lg5j6h00.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45117) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQClS-0003Xs-Pc for guix-devel@gnu.org; Fri, 23 Nov 2018 09:49:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQClO-00061c-Sg for guix-devel@gnu.org; Fri, 23 Nov 2018 09:49:02 -0500 In-reply-to: <87lg5j6h00.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: Guix-devel Hey! > Now, why does the default value of LANG matter anyway? I mean, the > installer starts out with a default language, presumably English, right? > So you can simply add, say, (setenv "LC_ALL" "en_US.utf8") when starting > the installer, can=E2=80=99t you? Yup its a way, but in the higly improbable case we want to distribute install images with the 'locale' field of 'installation-os' set to something else than en_US.utf8, then LANG matters. I found a hack consisting in loading everything in /etc/environment just before starting the installer but I'm not very proud of it! > 4. The installation system tests still work (e.g., > =E2=80=9Cmake check-system TESTS=3Dinstalled-os=E2=80=9D.) Normally= they won=E2=80=99t > require any modifications since they just run a Bash installation > script directly through the marionette. Yup, I'll check! > When do you think we could merge? I=E2=80=99d like to release by the end= of > next week or the week after at the latest. (If you think you can=E2=80= =99t make > it, that=E2=80=99s fine too, no pressure!) I just pushed to wip-newt-installer some commits. Most of what you described in points 1, 2 and 3 should be ok. The part, I'm not sure about and I would like you to have a look is the (guix self) part. I'm not sure I understand the point of having a *installer-modules* scheme-node if we don't want to build and distribute the installer via (guix self). So what I did is removing (gnu system install) from *system-modules* so that, all references to the installer is absent from (guix self), but maybe it's not the right thing to do. Thanks, Mathieu