From: Mark H Weaver <mhw@netris.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: 01/02: gnu: rhythmbox: Update hash of patch.
Date: Sun, 25 Nov 2018 16:31:56 -0500 [thread overview]
Message-ID: <87pnuskfmg.fsf@netris.org> (raw)
In-Reply-To: <87h8g5unug.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sun, 25 Nov 2018 17:24:39 +0100")
Hi Ludovic,
ludo@gnu.org (Ludovic Courtès) writes:
> guix-commits@gnu.org skribis:
>
>> commit e1d97c4efc42a661bd2772041371303e4070aa4f
>> Author: Mark H Weaver <mhw@netris.org>
>> Date: Mon Nov 5 04:04:45 2018 -0500
>>
>> gnu: rhythmbox: Update hash of patch.
>>
>> * gnu/packages/gnome.scm (rhythmbox)[source]: Update hash of the applied
>> patch.
>> ---
>> gnu/packages/gnome.scm | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
>> index 06ec28b..376cf5a 100644
>> --- a/gnu/packages/gnome.scm
>> +++ b/gnu/packages/gnome.scm
>> @@ -3746,7 +3746,7 @@ which can read a large number of file formats.")
>> "b182c6b9e1d09e601bac0b703cc5f8b159ebbc3a.patch"))
>> (sha256
>> (base32
>> - "17j45vyyr071ka3nckj2gycgyyv1j08fyrxw89jfdq2442nzrsiy")))))
>> + "06n87xgf927djmv1vshal84nqx7g8nwgljza3g2vydhy7g2n1csq")))))
>
> Could you explain the difference between the two patches?
>
> In general I think we should keep providing detailed explanations in the
> commit log (and possibly in the bug tracker) when such problems occur.
Agreed. Thanks for paying attention to these things :)
At the time that I first committed this patch to my private branch,
Hydra was offline, and it wasn't obvious to me how to get the old
version. However, I could see that the patch was so trivial that I
didn't worry about it. Still, I probably should have asked on the
mailing list.
Anyway, see below for the diff between the old patch and the new one.
Thanks,
Mark
--8<---------------cut here---------------start------------->8---
--- t.patch 2018-11-25 16:26:38.946968736 -0500
+++ b182c6b9e1d09e601bac0b703cc5f8b159ebbc3a.patch 2018-11-25 14:53:32.019264658 -0500
@@ -19,7 +19,7 @@
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/plugins/fmradio/rb-fm-radio-gst-src.c b/plugins/fmradio/rb-fm-radio-gst-src.c
-index 09d709c..88abdaf 100644
+index 09d709c28..88abdaf35 100644
--- a/plugins/fmradio/rb-fm-radio-gst-src.c
+++ b/plugins/fmradio/rb-fm-radio-gst-src.c
@@ -178,7 +178,7 @@ plugin_init (GstPlugin *plugin)
@@ -31,6 +31,6 @@
"element to output silence",
plugin_init,
VERSION,
---
-libgit2 0.27.1
+--
+2.18.1
--8<---------------cut here---------------end--------------->8---
next prev parent reply other threads:[~2018-11-25 21:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181124183051.23027.37347@vcs0.savannah.gnu.org>
[not found] ` <20181124183052.9A76B209A2@vcs0.savannah.gnu.org>
2018-11-25 16:24 ` 01/02: gnu: rhythmbox: Update hash of patch Ludovic Courtès
2018-11-25 21:31 ` Mark H Weaver [this message]
2018-11-28 11:04 ` Generated patches change over time Ludovic Courtès
2018-11-28 17:59 ` Mark H Weaver
2018-12-02 0:24 ` Ludovic Courtès
2018-11-29 14:48 ` Maxim Cournoyer
2018-12-01 21:37 ` Ludovic Courtès
2018-12-01 22:29 ` Mark H Weaver
2018-12-02 10:38 ` Ludovic Courtès
2018-12-02 19:36 ` Maxim Cournoyer
2018-12-02 20:33 ` Mark H Weaver
2018-12-31 2:12 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnuskfmg.fsf@netris.org \
--to=mhw@netris.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.