Re: 03/03: gnu: clang-from-llvm: Clean up share/clang folder.

Re: 03/03: gnu: clang-from-llvm: Clean up share/clang folder.

[Mark H Weaver]

Hi Pierre,

guix-commits@gnu.org writes:

> ambrevar pushed a commit to branch master
> in repository guix.
>
> commit 1c7372a5aadea84165376a4b8e2664b67a663c56
> Author: Pierre Neidhardt <mail@ambrevar.xyz>
> Date:   Mon Nov 26 14:51:40 2018 +0100
>
>     gnu: clang-from-llvm: Clean up share/clang folder.
>     
>     * gnu/packages/llvm.scm (clang-from-llvm): Remove useless files, install completion.

I guess you only tested this for clang@6.0.1.  It broke the builds for
_all_ other versions of clang.

  https://hydra.gnu.org/eval/110341?filter=clang#tabs-now-fail

For example, see below for the tail of the build log for clang-3.9.1 on
x86_64-linux.

     Regards,
       Mark

--8<---------------cut here---------------start------------->8---
phase `install' succeeded after 4.0 seconds
starting phase `install-clean-up-/share/clang'
Backtrace:
           7 (primitive-load "/gnu/store/9x14py3rqc0zlk131957r7a8lda…")
In ice-9/eval.scm:
   191:35  6 (_ _)
In srfi/srfi-1.scm:
    640:9  5 (for-each #<procedure c60ca0 at /gnu/store/qzsljkcllc0…> …)
In /gnu/store/qzsljkcllc01dmdq9z0yrqri3ajam3vp-module-import/guix/build/gnu-build-system.scm:
   799:31  4 (_ _)
In ice-9/eval.scm:
    619:8  3 (_ #(#(#<directory (guile-user) 7cc140>) (("out" . #))))
In ice-9/boot-9.scm:
    142:2  2 (dynamic-wind #<procedure e831e0 at ice-9/eval.scm:330…> …)
In ice-9/eval.scm:
    619:8  1 (_ #(#(#<directory (guile-user) 7cc140> "/gnu/store/…")))
In unknown file:
           0 (delete-file "clang-rename.el")

ERROR: In procedure delete-file:
In procedure delete-file: No such file or directory
builder for `/gnu/store/vc33s8dicyhzhysm90x2wli3n7q4y3si-clang-3.9.1.drv' failed with exit code 1
@ build-failed /gnu/store/vc33s8dicyhzhysm90x2wli3n7q4y3si-clang-3.9.1.drv - 1 builder for `/gnu/store/vc33s8dicyhzhysm90x2wli3n7q4y3si-clang-3.9.1.drv' failed with exit code 1
--8<---------------cut here---------------end--------------->8---

Re: 03/03: gnu: clang-from-llvm: Clean up share/clang folder.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]

On Tue, Nov 27, 2018 at 06:35:15PM -0500, Mark H Weaver wrote:
> Hi Pierre,
> 
> guix-commits@gnu.org writes:
> 
> > ambrevar pushed a commit to branch master
> > in repository guix.
> >
> > commit 1c7372a5aadea84165376a4b8e2664b67a663c56
> > Author: Pierre Neidhardt <mail@ambrevar.xyz>
> > Date:   Mon Nov 26 14:51:40 2018 +0100
> >
> >     gnu: clang-from-llvm: Clean up share/clang folder.
> >     
> >     * gnu/packages/llvm.scm (clang-from-llvm): Remove useless files, install completion.
> 
> I guess you only tested this for clang@6.0.1.  It broke the builds for
> _all_ other versions of clang.
> 
>   https://hydra.gnu.org/eval/110341?filter=clang#tabs-now-fail
> 
> For example, see below for the tail of the build log for clang-3.9.1 on
> x86_64-linux.
> 
>      Regards,
>        Mark
> 

I have a fix for this test-building clang@3.8 on my machine. I've
wrapped the delete-file calls in "(when file-exists?" and will push if
it builds with no problems.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: 03/03: gnu: clang-from-llvm: Clean up share/clang folder.

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

Sorry for the mess, that was an obvious mistake, I should have thought twice
about it before pushing.

Efraim, let me know if you can't push, then I'll do it.

That said, I wonder why we need so many old Clangs.  For instance, I see we only
use clang-3.9.1 for DarkTable and c-reduce.  c-reduce could be updated according
to the comment.  And DarkTable builds fine with clang 7 according to Arch Linux.
(Maybe they are wrong.)

Either way, I think it would be a good idea to always comment why some specific
version of a program has to be used, lest we see a plethora of versions grow,
which makes maintenance a bit harder sometimes.

Thoughts?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: 03/03: gnu: clang-from-llvm: Clean up share/clang folder.

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

I've successfully built clang-3.9.1 with two (file-exists? ...).
Efraim, let me know if I should push.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: 03/03: gnu: clang-from-llvm: Clean up share/clang folder.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 2281 bytes --]

On Wed, Nov 28, 2018 at 11:23:55AM +0100, Pierre Neidhardt wrote:
> I've successfully built clang-3.9.1 with two (file-exists? ...).
> Efraim, let me know if I should push.
> 

If yours works then go ahead and push it. I forgot to check
bash-autocomplete.sh and so my build of clang@3.8 failed. Make sure
yours covers that too.

diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm
index 0b12f736a..6197c2795 100644
--- a/gnu/packages/llvm.scm
+++ b/gnu/packages/llvm.scm
@@ -243,13 +243,16 @@ compiler.  In LLVM this library is called \"compiler-rt\".")
                                          out "/etc/bash_completion.d")))
                         (with-directory-excursion (string-append out
                                                                  "/share/clang")
-                          ;; Delete extensions for proprietary text editors.
-                          (delete-file "clang-format-bbedit.applescript")
-                          (delete-file "clang-format-sublime.py")
-                          ;; Delete Emacs extensions: see their respective Emacs
-                          ;; Guix package instead.
-                          (delete-file "clang-rename.el")
-                          (delete-file "clang-format.el")
+                          (for-each
+                            (lambda (file)
+                              (when (file-exists? file)
+                                (delete-file file)))
+                            ;; Delete extensions for proprietary text editors.
+                            '("clang-format-bbedit.applescript"
+                              "clang-format-sublime.py"
+                              ;; Delete Emacs extensions: see their respective Emacs
+                              ;; Guix package instead.
+                              "clang-rename.el" "clang-format.el"))
                           ;; Install bash completion.
                           (mkdir-p compl-dir)
                           (rename-file "bash-autocomplete.sh"


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: 03/03: gnu: clang-from-llvm: Clean up share/clang folder.

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 55 bytes --]

Done!

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: 03/03: gnu: clang-from-llvm: Clean up share/clang folder.

[Ludovic Courtès]

Hello all,

Efraim Flashner <efraim@flashner.co.il> skribis:

> On Tue, Nov 27, 2018 at 06:35:15PM -0500, Mark H Weaver wrote:
>> Hi Pierre,
>> 
>> guix-commits@gnu.org writes:
>> 
>> > ambrevar pushed a commit to branch master
>> > in repository guix.
>> >
>> > commit 1c7372a5aadea84165376a4b8e2664b67a663c56
>> > Author: Pierre Neidhardt <mail@ambrevar.xyz>
>> > Date:   Mon Nov 26 14:51:40 2018 +0100
>> >
>> >     gnu: clang-from-llvm: Clean up share/clang folder.
>> >     
>> >     * gnu/packages/llvm.scm (clang-from-llvm): Remove useless files, install completion.
>> 
>> I guess you only tested this for clang@6.0.1.  It broke the builds for
>> _all_ other versions of clang.
>> 
>>   https://hydra.gnu.org/eval/110341?filter=clang#tabs-now-fail
>> 
>> For example, see below for the tail of the build log for clang-3.9.1 on
>> x86_64-linux.
>> 
>>      Regards,
>>        Mark
>> 
>
> I have a fix for this test-building clang@3.8 on my machine. I've
> wrapped the delete-file calls in "(when file-exists?" and will push if
> it builds with no problems.

Yes, please do!  We can’t let Clang broken for this long.

Thanks,
Ludo’.