bug#31868: Tests failures for GnuCash 3.0

bug#31868: Tests failures for GnuCash 3.0

[Maxim Cournoyer]

I could reproduce the following test failures twice on my machine:

--8<---------------cut here---------------start------------->8---
102/102 Test #102: test-load-report-stylesheets-module ..........   Passed    1.58 sec

96% tests passed, 4 tests failed out of 102

Total Test time (real) =  73.37 sec

The following tests FAILED:
         22 - test-real-data (Failed)
         34 - test-qof (Child aborted)
         58 - test-gnc-timezone (Failed)
         85 - test-tokenizer (Failed)
Errors while running CTest
make[3]: *** [CMakeFiles/check.dir/build.make:60: CMakeFiles/check] Error 8
make[3]: Leaving directory '/tmp/guix-build-gnucash-3.0.drv-0/build'
make[2]: *** [CMakeFiles/Makefile2:242: CMakeFiles/check.dir/all] Error 2
make[2]: Leaving directory '/tmp/guix-build-gnucash-3.0.drv-0/build'
make[1]: *** [CMakeFiles/Makefile2:249: CMakeFiles/check.dir/rule] Error 2
make[1]: Leaving directory '/tmp/guix-build-gnucash-3.0.drv-0/build'
make: *** [Makefile:226: check] Error 2

Test suite failed, dumping logs.
Backtrace:
           4 (primitive-load "/gnu/store/lc1yxn26cdw0psp8ycmflwa76js…")
In ice-9/eval.scm:
   191:35  3 (_ _)
In srfi/srfi-1.scm:
    640:9  2 (for-each #<procedure 9ed9e0 at /gnu/store/qzsljkcllc0…> …)
In /gnu/store/qzsljkcllc01dmdq9z0yrqri3ajam3vp-module-import/guix/build/gnu-build-system.scm:
   799:31  1 (_ _)
    369:6  0 (check #:target _ #:make-flags _ #:tests? _ # _ # _ # _)

/gnu/store/qzsljkcllc01dmdq9z0yrqri3ajam3vp-module-import/guix/build/gnu-build-system.scm:369:6: In procedure check:
Throw to key `srfi-34' with args `(#<condition &invoke-error [program: "make" arguments: ("check") exit-status: 2 term-signal: #f stop-signal: #f] 68fd40>)'.
builder for `/gnu/store/2dzy162bvwfcxs7a05arxiqq7g6xfsjx-gnucash-3.0.drv' failed with exit code 1
guix package: error: build failed: build of `/gnu/store/2dzy162bvwfcxs7a05arxiqq7g6xfsjx-gnucash-3.0.drv' failed
--8<---------------cut here---------------end--------------->8---

Maxim

bug#31868: Test failure for GnuCash 3.3 (previously 3.0)

[Maxim Cournoyer]

Using latest Guix, GnuCash 3.3 fails its test suite by only one test:

--8<---------------cut here---------------start------------->8---
[fail] line:644, test: dual amount column, first transaction correct
transaction.scm/display options
 -> expected: ("01/03/18" "$103 income" "Root.Asset.Bank" "$103.00" "$103.00")
 -> obtained: ("01/03/19" "$103 income" "Root.Asset.Bank" "$103.00" "$103.00")
 --8<---------------cut here---------------end--------------->8---

bug#31868: Test failure for GnuCash 3.3 (previously 3.0)

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 850 bytes --]

On Tue, Jan 01, 2019 at 03:15:09PM -0500, Maxim Cournoyer wrote:
> Using latest Guix, GnuCash 3.3 fails its test suite by only one test:
> 
> --8<---------------cut here---------------start------------->8---
> [fail] line:644, test: dual amount column, first transaction correct
> transaction.scm/display options
>  -> expected: ("01/03/18" "$103 income" "Root.Asset.Bank" "$103.00" "$103.00")
>  -> obtained: ("01/03/19" "$103 income" "Root.Asset.Bank" "$103.00" "$103.00")
>  --8<---------------cut here---------------end--------------->8---
> 

Haven't looked at the test yet, is this a 'yyyy' vs 'YYYY' error in ISO8601?

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#31868: Test failure for GnuCash 3.3 (previously 3.0)

[Ricardo Wurmus]

Efraim Flashner <efraim@flashner.co.il> writes:

> On Tue, Jan 01, 2019 at 03:15:09PM -0500, Maxim Cournoyer wrote:
>> Using latest Guix, GnuCash 3.3 fails its test suite by only one test:
>> 
>> --8<---------------cut here---------------start------------->8---
>> [fail] line:644, test: dual amount column, first transaction correct
>> transaction.scm/display options
>>  -> expected: ("01/03/18" "$103 income" "Root.Asset.Bank" "$103.00" "$103.00")
>>  -> obtained: ("01/03/19" "$103 income" "Root.Asset.Bank" "$103.00" "$103.00")
>>  --8<---------------cut here---------------end--------------->8---
>> 
>
> Haven't looked at the test yet, is this a 'yyyy' vs 'YYYY' error in ISO8601?

To me this looks like the test assumes that we’re running it in 2018,
not $current_year.

-- 
Ricardo

bug#31868: Test failure for GnuCash 3.3 (previously 3.0)

[Maxim Cournoyer]

Ricardo Wurmus <rekado@elephly.net> writes:

> Efraim Flashner <efraim@flashner.co.il> writes:
>
>> On Tue, Jan 01, 2019 at 03:15:09PM -0500, Maxim Cournoyer wrote:
>>> Using latest Guix, GnuCash 3.3 fails its test suite by only one test:
>>> 
>>> --8<---------------cut here---------------start------------->8---
>>> [fail] line:644, test: dual amount column, first transaction correct
>>> transaction.scm/display options
>>>  -> expected: ("01/03/18" "$103 income" "Root.Asset.Bank" "$103.00" "$103.00")
>>>  -> obtained: ("01/03/19" "$103 income" "Root.Asset.Bank" "$103.00" "$103.00")
>>>  --8<---------------cut here---------------end--------------->8---
>>> 
>>
>> Haven't looked at the test yet, is this a 'yyyy' vs 'YYYY' error in ISO8601?
>
> To me this looks like the test assumes that we’re running it in 2018,
> not $current_year.

Good flair; it turned out to be exactly this.

Fixed with commit 707efe171a4e0e542a7d969c130195fa94b5d615. Closing.

Thank you,

Maxim