* Re: 03/04: gnu: Replace all cons* with beginner-friendly (append (list ...)).
[not found] ` <20190121211229.A391C209D7@vcs0.savannah.gnu.org>
@ 2019-01-22 13:06 ` Ludovic Courtès
2019-01-22 14:06 ` Pierre Neidhardt
0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2019-01-22 13:06 UTC (permalink / raw)
To: guix-devel, Pierre Neidhardt
Hello!
guix-commits@gnu.org skribis:
> + (packages (append (list ratpoison i3-wm i3status dmenu ;window managers
> + nss-certs ;for HTTPS access
> + )
[...]
> + (packages (append (list nvi fdisk
> + grub ; mostly so xrefs to its manual work
> + parted ; partprobe
> + )
Please don’t leave hanging parens—we want to teach people the Right Way
to format code. ;-)
Also, you may be able to remove (srfi srfi-1) imports from these
examples.
Last, make sure the text in guix.texi that explains these examples does
not mention ‘cons*’.
Thanks!
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: 03/04: gnu: Replace all cons* with beginner-friendly (append (list ...)).
2019-01-22 13:06 ` 03/04: gnu: Replace all cons* with beginner-friendly (append (list ...)) Ludovic Courtès
@ 2019-01-22 14:06 ` Pierre Neidhardt
2019-01-23 11:01 ` Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: Pierre Neidhardt @ 2019-01-22 14:06 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 921 bytes --]
> Please don’t leave hanging parens—we want to teach people the Right Way
> to format code. ;-)
I've always wondered what's the recommendation for closing parentheses after
inline comments.
In general, I refrain from using inline comments so I would do this:
--8<---------------cut here---------------start------------->8---
(packages (append (list nvi fdisk
;; mostly so xrefs to its manual work:
grub
;; partprobe:
parted)
--8<---------------cut here---------------end--------------->8---
> Last, make sure the text in guix.texi that explains these examples does
> not mention ‘cons*’.
My rationale here was that I've switched to "(append (list...))" until the first time we explain
cons*, then I left the cons*.
--
Pierre Neidhardt
https://ambrevar.xyz/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: 03/04: gnu: Replace all cons* with beginner-friendly (append (list ...)).
2019-01-22 14:06 ` Pierre Neidhardt
@ 2019-01-23 11:01 ` Ludovic Courtès
2019-01-23 11:23 ` Pierre Neidhardt
0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2019-01-23 11:01 UTC (permalink / raw)
To: Pierre Neidhardt; +Cc: guix-devel
Pierre Neidhardt <mail@ambrevar.xyz> skribis:
>> Please don’t leave hanging parens—we want to teach people the Right Way
>> to format code. ;-)
>
> I've always wondered what's the recommendation for closing parentheses after
> inline comments.
You mean “margin comments” (to the right)?
> In general, I refrain from using inline comments so I would do this:
>
> (packages (append (list nvi fdisk
> ;; mostly so xrefs to its manual work:
> grub
> ;; partprobe:
> parted)
That would work as well. Either way: no hanging parens. :-)
>> Last, make sure the text in guix.texi that explains these examples does
>> not mention ‘cons*’.
>
> My rationale here was that I've switched to "(append (list...))" until the first time we explain
> cons*, then I left the cons*.
Oh OK, perfect!
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-23 11:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190121211227.11235.26515@vcs0.savannah.gnu.org>
[not found] ` <20190121211229.A391C209D7@vcs0.savannah.gnu.org>
2019-01-22 13:06 ` 03/04: gnu: Replace all cons* with beginner-friendly (append (list ...)) Ludovic Courtès
2019-01-22 14:06 ` Pierre Neidhardt
2019-01-23 11:01 ` Ludovic Courtès
2019-01-23 11:23 ` Pierre Neidhardt
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.